From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52284)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZdBYi-0004lL-Mt
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 02:23:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZdBYf-0002jT-KD
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 02:23:40 -0400
Received: from mx2.suse.de ([195.135.220.15]:45601)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZdBYf-0002ie-EY
	for qemu-devel@nongnu.org; Sat, 19 Sep 2015 02:23:37 -0400
References: <1440107676-17326-1-git-send-email-ehabkost@redhat.com>
	<1440107676-17326-11-git-send-email-ehabkost@redhat.com>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <55FCFF66.8070609@suse.de>
Date: Sat, 19 Sep 2015 08:23:34 +0200
MIME-Version: 1.0
In-Reply-To: <1440107676-17326-11-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name
 automatically
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>, Marcel Apfelbaum <marcel.a@redhat.com>

Am 20.08.2015 um 23:54 schrieb Eduardo Habkost:
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 5ba4b80..af985f6 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -960,7 +960,6 @@ static void virt_class_init(ObjectClass *oc, void *=
data)
>  {
>      MachineClass *mc =3D MACHINE_CLASS(oc);
> =20
> -    mc->name =3D VIRT_MACHINE_NAME;
>      mc->desc =3D "ARM Virtual Machine",
>      mc->init =3D machvirt_init;
>      mc->max_cpus =3D 8;

I am going to squash the following cleanup reverting 04/10 change:

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 49eb4fa..6bf0d6d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -83,8 +83,7 @@ typedef struct {
     bool highmem;
 } VirtMachineState;

-#define VIRT_MACHINE_NAME   "virt"
-#define TYPE_VIRT_MACHINE   MACHINE_TYPE_NAME(VIRT_MACHINE_NAME)
+#define TYPE_VIRT_MACHINE   MACHINE_TYPE_NAME("virt")
 #define VIRT_MACHINE(obj) \
     OBJECT_CHECK(VirtMachineState, (obj), TYPE_VIRT_MACHINE)
 #define VIRT_MACHINE_GET_CLASS(obj) \

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)