From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init()
Date: Mon, 21 Sep 2015 10:04:18 +0200 [thread overview]
Message-ID: <55FFBA02.5070501@de.ibm.com> (raw)
In-Reply-To: <1442677004-4482-3-git-send-email-afaerber@suse.de>
Am 19.09.2015 um 17:36 schrieb Andreas Färber:
> Here, machine_init() is being misused to initialize global variables.
> Being all local, it's safe to use the slightly earlier type_init().
>
> This prepares for dropping machine_init().
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
I think this should go via your tree to coordinate with machine_init removal.
> ---
> hw/s390x/css.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index c033612..d164fa8 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -1509,7 +1509,7 @@ static void css_init(void)
> channel_subsys->chnmon_active = false;
> QTAILQ_INIT(&channel_subsys->io_adapters);
> }
> -machine_init(css_init);
> +type_init(css_init)
>
> void css_reset_sch(SubchDev *sch)
> {
>
next prev parent reply other threads:[~2015-09-21 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 15:36 [Qemu-devel] [PATCH 0/6] machine: Deprecate machine_init() Andreas Färber
2015-09-19 15:36 ` [Qemu-devel] [PATCH 1/6] Use type_init() for all machine QOM types Andreas Färber
2015-09-19 15:36 ` [Qemu-devel] [PATCH 2/6] hw/s390x/css: Use type_init() instead of machine_init() Andreas Färber
2015-09-21 8:04 ` Christian Borntraeger [this message]
2015-09-19 15:36 ` [Qemu-devel] [PATCH 3/6] Introduce config_init() for QemuOpts Andreas Färber
2015-09-19 15:36 ` [Qemu-devel] [PATCH 4/6] Drop machine_init() and MODULE_INIT_MACHINE Andreas Färber
2015-09-19 15:36 ` [Qemu-devel] [PATCH 5/6] exynos4: Further QOM'ify machines Andreas Färber
2015-09-19 15:36 ` [Qemu-devel] [PATCH 6/6] pc: Use type_register_static() for machine types Andreas Färber
2015-09-21 15:53 ` [Qemu-devel] [PATCH 0/6] machine: Deprecate machine_init() Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FFBA02.5070501@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).