qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Warner Losh <imp@bsdimp.com>, Roman Bolshakov <r.bolshakov@yadro.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	"Stefan Weil" <sw@weilnetz.de>
Subject: Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release
Date: Fri, 19 Mar 2021 13:01:07 +0100	[thread overview]
Message-ID: <55ba912d-1310-6863-4223-87b81efaac57@redhat.com> (raw)
In-Reply-To: <ad56d549-295f-20cf-593c-4aa677fcb19e@redhat.com>

On 09/03/2021 06.08, Thomas Huth wrote:
> On 08/03/2021 20.57, Warner Losh wrote:
>>
>>
>> On Mon, Mar 8, 2021 at 12:51 PM Warner Losh <imp@bsdimp.com 
>> <mailto:imp@bsdimp.com>> wrote:
>>
>>
>>
>>     On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov <r.bolshakov@yadro.com
>>     <mailto:r.bolshakov@yadro.com>> wrote:
>>
>>
>>          > 8 марта 2021 г., в 18:41, Thomas Huth <thuth@redhat.com
>>         <mailto:thuth@redhat.com>> написал(а):
>>          >
>>          > On 08/03/2021 16.26, Warner Losh wrote:
>>          >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth <thuth@redhat.com
>>         <mailto:thuth@redhat.com> <mailto:thuth@redhat.com
>>         <mailto:thuth@redhat.com>>> wrote:
>>          >>    On 07/03/2021 16.56, Warner Losh wrote:
>>          >>     > FreeBSD 12.1 has reached end of life. Use 12.2 instead so
>>         that FreeBSD's
>>          >>     > project's packages will work.  Update which timezone to
>>         pick. Work
>>          >>    around a QEMU
>>          >>     > bug that incorrectly raises an exception on a CRC32
>>         instruction with
>>          >>    the FPU
>>          >>     > disabled.  The qemu bug is described here:
>>          >>     >
>>         https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html
>>         <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html>
>>          >>         
>> <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html
>>         <https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html>>
>>          >>     >
>>          >>     > Signed-off-by: Warner Losh <imp@bsdimp.com
>>         <mailto:imp@bsdimp.com> <mailto:imp@bsdimp.com 
>> <mailto:imp@bsdimp.com>>>
>>          >>     >
>>          >>     > ---
>>          >>     >   tests/vm/freebsd | 14 +++++++++-----
>>          >>     >   1 file changed, 9 insertions(+), 5 deletions(-)
>>          >>    I gave this a try, but it's currently failing in the unit 
>> tests:
>>          >>    Running test test-crypto-tlscredsx509
>>          >>    ** (tests/test-crypto-tlscredsx509:9999): CRITICAL **:
>>         12:56:35.157: Failed
>>          >>    to sign certificate ASN1 parser: Value is not valid.
>>          >>    ERROR test-crypto-tlscredsx509 - Bail out! FATAL-CRITICAL:
>>         Failed to sign
>>          >>    certificate ASN1 parser: Value is not valid.
>>          >>    gmake: *** [Makefile.mtest:576: run-test-70] Error 1
>>          >>    gmake: *** Waiting for unfinished jobs....
>>          >>    Running test test-crypto-tlssession
>>          >>    ** (tests/test-crypto-tlssession:10002): CRITICAL **:
>>         12:56:35.288: Failed
>>          >>    to sign certificate ASN1 parser: Value is not valid.
>>          >>    ERROR test-crypto-tlssession - Bail out! FATAL-CRITICAL:
>>         Failed to sign
>>          >>    certificate ASN1 parser: Value is not valid.
>>          >> That's totally unrelated to my change. Was it failing before?
>>         What environment was it failing in because it all seemed to work for
>>         me...
>>          >
>>          > It's been a while since I last ran "make vm-build-freebsd", so I
>>         can't really tell whether the problem was already there before ...
>>         when I now try to run it without your patch, it fails for me, too,
>>         but rather due to FreeBSD 12.1 being out of service instead.
>>          >
>>          >>    I guess it's the same problem as:
>>          >>
>>         https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html
>>         <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html>
>>          >>         
>> <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html
>>         
>> <https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html>>
>>          >>    ... so this would require a bug fix in the libtasn of FreeBSD
>>         first? See:
>>          >> https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
>>         <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71>
>>          >>    <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
>>         <https://gitlab.com/gnutls/libtasn1/-/merge_requests/71>>
>>          >>  Is this on the host that built qemu, or inside the VM or where
>>         exactly?
>>          >
>>          > It's inside the VM ... I assume the libtasn there has the same
>>         bug as the one on macOS?
>>          >
>>
>>         The gnutls failures on macOS and FreeBSD (with clang as main
>>         compiler) won’t happen only if libtasn1 from master is used.
>>         Otherwise libtasn1 has to be compiled with -O1/-O0.
>>
>>
>>     Forgive my ignorance...
>>
>>     Does this come from a submodule? From something I've built and installed
>>     on my FreeBSD host? Or something that's installed into the FreeBSD guest
>>
>>
>> ah, it's inside the guest.
> 
> Yes, IIUC it's the pre-installed libtasn1 in the guest, and the problem 
> likely occurs just now since the clang that has been used to compile the 
> library has been updated, too?
> 
> Anyway, can you reproduce the issue? If so, could you please file a bug 
> ticket against libtasn1 there, so that it gets fixed? (sorry, I don't have 
> any clue about the FreeBSD process here)

For the time being, I suggest we add this hunk to your patch here to get
the VM-build going again:

diff --git a/tests/vm/freebsd b/tests/vm/freebsd
--- a/tests/vm/freebsd
+++ b/tests/vm/freebsd
@@ -46,7 +46,9 @@ class FreeBSDVM(basevm.BaseVM):
          "gettext",
  
          # libs: crypto
-        "gnutls",
+        # TODO: Enable gnutls again once FreeBSD's libtasn1 got fixed
+        # See: https://gitlab.com/gnutls/libtasn1/-/merge_requests/71
+        # "gnutls",
  
          # libs: images
          "jpeg-turbo",

  Thomas



  reply	other threads:[~2021-03-19 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-07 15:56 RESEND [PATCH v2] bsd-user: Add new maintainers Warner Losh
2021-03-07 15:56 ` [PATCH v2] FreeBSD: Upgrade to 12.2 release Warner Losh
2021-03-08 13:30   ` Thomas Huth
2021-03-08 15:26     ` Warner Losh
2021-03-08 15:31       ` Daniel P. Berrangé
2021-03-08 15:41       ` Thomas Huth
2021-03-08 15:46         ` Roman Bolshakov
2021-03-08 16:49           ` Stefan Weil
2021-03-08 19:51           ` Warner Losh
2021-03-08 19:57             ` Warner Losh
2021-03-09  5:08               ` Thomas Huth
2021-03-19 12:01                 ` Thomas Huth [this message]
2021-03-08 10:09 ` RESEND [PATCH v2] bsd-user: Add new maintainers Thomas Huth
2021-03-08 10:24   ` Peter Maydell
2021-03-08 11:16     ` Philippe Mathieu-Daudé
2021-03-08 11:49       ` Peter Maydell
2021-03-08 11:55       ` Thomas Huth
2021-03-08 12:01         ` Peter Maydell
2021-03-08 12:14         ` Daniel P. Berrangé
2021-03-08 13:14           ` Philippe Mathieu-Daudé
2021-03-08 15:21             ` Warner Losh
2021-03-08 15:27               ` Daniel P. Berrangé
2021-03-08 19:59                 ` Warner Losh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ba912d-1310-6863-4223-87b81efaac57@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=imp@bsdimp.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).