From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5A8C433E0 for ; Fri, 19 Mar 2021 12:02:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8DD764F65 for ; Fri, 19 Mar 2021 12:02:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8DD764F65 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNDqB-0007iL-Nq for qemu-devel@archiver.kernel.org; Fri, 19 Mar 2021 08:02:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNDoe-0006tA-7K for qemu-devel@nongnu.org; Fri, 19 Mar 2021 08:01:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lNDob-0004dV-0Y for qemu-devel@nongnu.org; Fri, 19 Mar 2021 08:01:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616155275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AVrvOVZZQGDNc2XyQC6PpmCDJMY7hejr1UC3Qe0lN9I=; b=EVSp8q5i5lGD132zps0T5rrUXZG+A3Uxx3iauI1WqygA9pK1qGeO+ct0GW5uI7CezJJqu+ OATeUR270qH8nbRTMBwbFZ2tGHJVzOMtCUUaso/2YZDlYF4SpO1475eRi5npAwm+/YP+gn nMglZzVwGhaYfsIw42s7LT+oFNqxNbw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-558-D_vdOh15NtW7u1uAtXXl6A-1; Fri, 19 Mar 2021 08:01:11 -0400 X-MC-Unique: D_vdOh15NtW7u1uAtXXl6A-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52DCF593A5; Fri, 19 Mar 2021 12:01:10 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-49.ams2.redhat.com [10.36.112.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id 665C8189A5; Fri, 19 Mar 2021 12:01:08 +0000 (UTC) Subject: Re: [PATCH v2] FreeBSD: Upgrade to 12.2 release From: Thomas Huth To: Warner Losh , Roman Bolshakov References: <20210307155654.993-1-imp@bsdimp.com> <20210307155654.993-2-imp@bsdimp.com> Message-ID: <55ba912d-1310-6863-4223-87b81efaac57@redhat.com> Date: Fri, 19 Mar 2021 13:01:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , "Daniel P. Berrange" , QEMU Developers , Stefan Weil Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 09/03/2021 06.08, Thomas Huth wrote: > On 08/03/2021 20.57, Warner Losh wrote: >> >> >> On Mon, Mar 8, 2021 at 12:51 PM Warner Losh > > wrote: >> >> >> >>     On Mon, Mar 8, 2021 at 8:46 AM Roman Bolshakov >     > wrote: >> >> >>          > 8 марта 2021 г., в 18:41, Thomas Huth >         > написал(а): >>          > >>          > On 08/03/2021 16.26, Warner Losh wrote: >>          >> On Mon, Mar 8, 2021 at 6:30 AM Thomas Huth >         >         >> wrote: >>          >>    On 07/03/2021 16.56, Warner Losh wrote: >>          >>     > FreeBSD 12.1 has reached end of life. Use 12.2 instead so >>         that FreeBSD's >>          >>     > project's packages will work.  Update which timezone to >>         pick. Work >>          >>    around a QEMU >>          >>     > bug that incorrectly raises an exception on a CRC32 >>         instruction with >>          >>    the FPU >>          >>     > disabled.  The qemu bug is described here: >>          >>     > >>         https://www.mail-archive.com/qemu-devel@nongnu.org/msg784158.html >>         >>          >> >> >         > >>          >>     > >>          >>     > Signed-off-by: Warner Losh >         > >> >>          >>     > >>          >>     > --- >>          >>     >   tests/vm/freebsd | 14 +++++++++----- >>          >>     >   1 file changed, 9 insertions(+), 5 deletions(-) >>          >>    I gave this a try, but it's currently failing in the unit >> tests: >>          >>    Running test test-crypto-tlscredsx509 >>          >>    ** (tests/test-crypto-tlscredsx509:9999): CRITICAL **: >>         12:56:35.157: Failed >>          >>    to sign certificate ASN1 parser: Value is not valid. >>          >>    ERROR test-crypto-tlscredsx509 - Bail out! FATAL-CRITICAL: >>         Failed to sign >>          >>    certificate ASN1 parser: Value is not valid. >>          >>    gmake: *** [Makefile.mtest:576: run-test-70] Error 1 >>          >>    gmake: *** Waiting for unfinished jobs.... >>          >>    Running test test-crypto-tlssession >>          >>    ** (tests/test-crypto-tlssession:10002): CRITICAL **: >>         12:56:35.288: Failed >>          >>    to sign certificate ASN1 parser: Value is not valid. >>          >>    ERROR test-crypto-tlssession - Bail out! FATAL-CRITICAL: >>         Failed to sign >>          >>    certificate ASN1 parser: Value is not valid. >>          >> That's totally unrelated to my change. Was it failing before? >>         What environment was it failing in because it all seemed to work for >>         me... >>          > >>          > It's been a while since I last ran "make vm-build-freebsd", so I >>         can't really tell whether the problem was already there before ... >>         when I now try to run it without your patch, it fails for me, too, >>         but rather due to FreeBSD 12.1 being out of service instead. >>          > >>          >>    I guess it's the same problem as: >>          >> >>         https://lists.gnu.org/archive/html/qemu-devel/2021-01/msg06750.html >>         >>          >> >> > >> > >>          >>    ... so this would require a bug fix in the libtasn of FreeBSD >>         first? See: >>          >> https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 >>         >>          >>    >         > >>          >>  Is this on the host that built qemu, or inside the VM or where >>         exactly? >>          > >>          > It's inside the VM ... I assume the libtasn there has the same >>         bug as the one on macOS? >>          > >> >>         The gnutls failures on macOS and FreeBSD (with clang as main >>         compiler) won’t happen only if libtasn1 from master is used. >>         Otherwise libtasn1 has to be compiled with -O1/-O0. >> >> >>     Forgive my ignorance... >> >>     Does this come from a submodule? From something I've built and installed >>     on my FreeBSD host? Or something that's installed into the FreeBSD guest >> >> >> ah, it's inside the guest. > > Yes, IIUC it's the pre-installed libtasn1 in the guest, and the problem > likely occurs just now since the clang that has been used to compile the > library has been updated, too? > > Anyway, can you reproduce the issue? If so, could you please file a bug > ticket against libtasn1 there, so that it gets fixed? (sorry, I don't have > any clue about the FreeBSD process here) For the time being, I suggest we add this hunk to your patch here to get the VM-build going again: diff --git a/tests/vm/freebsd b/tests/vm/freebsd --- a/tests/vm/freebsd +++ b/tests/vm/freebsd @@ -46,7 +46,9 @@ class FreeBSDVM(basevm.BaseVM): "gettext", # libs: crypto - "gnutls", + # TODO: Enable gnutls again once FreeBSD's libtasn1 got fixed + # See: https://gitlab.com/gnutls/libtasn1/-/merge_requests/71 + # "gnutls", # libs: images "jpeg-turbo", Thomas