From: "Su Hang" <suhang16@mails.ucas.ac.cn>
To: fam zheng <famz@redhat.com>
Cc: peter.maydell@linaro.org, eblake@redhat.com,
vsementsov@virtuozzo.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix
Date: Fri, 16 Mar 2018 14:31:56 +0800 (GMT+08:00) [thread overview]
Message-ID: <55c3c49b.14dfc.1622d81fc86.Coremail.suhang16@mails.ucas.ac.cn> (raw)
In-Reply-To: <20180316061520.GA27549@lemon.usersys.redhat.com>
Because I generate my first patch on master, it should work.
I have a little trouble understanding what Mr.Peter wants me to do,
would you please spare a little of your time and have a look at it?
It will help me. Please...
Su Hang
> -----Original Messages-----
> From: "Fam Zheng" <famz@redhat.com>
> Sent Time: 2018-03-16 14:15:20 (Friday)
> To: "Su Hang" <suhang16@mails.ucas.ac.cn>
> Cc: peter.maydell@linaro.org, eblake@redhat.com, vsementsov@virtuozzo.com, qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix
>
> On Fri, 03/16 10:58, Su Hang wrote:
> > (Sorry, I don't know this patch should base on which commit,
> > so I generate this patch based on
> > commit:fb8446d94ec7a3dc0c3a7e7da672406476f075ac,
> > I choose this by `git log -2 scripts/checkpath.pl`.
> > Sincerely say sorry, if I have misunderstand any meaning.)
>
> This should base on master. Basing on an older commit will only make it hard for
> maintainers to apply it.
>
> (Don't be sorry at all, thank you for spending your time improving QEMU!)
>
> Fam
next prev parent reply other threads:[~2018-03-16 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 2:58 [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix Su Hang
2018-03-16 6:15 ` Fam Zheng
2018-03-16 6:31 ` Su Hang [this message]
2018-03-16 7:08 ` Fam Zheng
2018-03-16 7:13 ` Su Hang
-- strict thread matches above, loose matches on Subject: below --
2018-04-03 15:17 [Qemu-devel] [PATCH 0/2 RFC] Implement Hex file loader and add test case Su Hang
2018-04-03 15:17 ` [Qemu-devel] [PATCH v2] scripts/checkpatch.pl: Bug fix Su Hang
2018-04-03 15:29 ` Su Hang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55c3c49b.14dfc.1622d81fc86.Coremail.suhang16@mails.ucas.ac.cn \
--to=suhang16@mails.ucas.ac.cn \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).