From: Damien Hedde <damien.hedde@greensocs.com>
To: Yanan Wang <wangyanan55@huawei.com>,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Cc: wanghaibin.wang@huawei.com, "Andrew Jones" <drjones@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>
Subject: Re: [PATCH 1/2] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus]
Date: Tue, 28 Sep 2021 12:40:24 +0200 [thread overview]
Message-ID: <55d7b2c8-56fa-b157-be2c-df43f7548fe6@greensocs.com> (raw)
In-Reply-To: <20210928093157.14620-2-wangyanan55@huawei.com>
On 9/28/21 11:31, Yanan Wang wrote:
> In qemu-option.hx, there is "-smp [[cpus=]n][,maxcpus=cpus]..." in the
> DEF part, and "-smp [[cpus=]n][,maxcpus=maxcpus]..." in the RST part.
> Obviously the later is right, let's fix the previous one.
>
> Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
> ---
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
> qemu-options.hx | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5c1b0311c0..dcd9595650 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -200,7 +200,7 @@ SRST
> ERST
>
> DEF("smp", HAS_ARG, QEMU_OPTION_smp,
> - "-smp [[cpus=]n][,maxcpus=cpus][,sockets=sockets][,dies=dies][,cores=cores][,threads=threads]\n"
> + "-smp [[cpus=]n][,maxcpus=maxcpus][,sockets=sockets][,dies=dies][,cores=cores][,threads=threads]\n"
> " set the number of CPUs to 'n' [default=1]\n"
> " maxcpus= maximum number of total CPUs, including\n"
> " offline CPUs for hotplug, etc\n"
>
next prev parent reply other threads:[~2021-09-28 10:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 9:31 [PATCH 0/2] qemu-options: Trivial doc fixes related to -smp Yanan Wang
2021-09-28 9:31 ` [PATCH 1/2] qemu-options: Tweak [, maxcpus=cpus] to [, maxcpus=maxcpus] Yanan Wang
2021-09-28 10:40 ` Damien Hedde [this message]
2021-09-28 9:31 ` [PATCH 2/2] qemu-options: Add missing "sockets=2" to CLI "-smp 2" Yanan Wang
2021-09-28 10:46 ` Philippe Mathieu-Daudé
2021-09-28 10:58 ` wangyanan (Y)
2021-09-28 11:01 ` Daniel P. Berrangé
2021-09-28 11:42 ` wangyanan (Y)
2021-09-28 11:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55d7b2c8-56fa-b157-be2c-df43f7548fe6@greensocs.com \
--to=damien.hedde@greensocs.com \
--cc=berrange@redhat.com \
--cc=drjones@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).