From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3673C433DF for ; Wed, 24 Jun 2020 07:52:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBBDC2085B for ; Wed, 24 Jun 2020 07:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FdFMNlK3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBBDC2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jo0CR-0003MH-S2 for qemu-devel@archiver.kernel.org; Wed, 24 Jun 2020 03:52:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jo0Be-0002sF-Sf for qemu-devel@nongnu.org; Wed, 24 Jun 2020 03:51:14 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23497 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jo0BQ-0005Nk-0h for qemu-devel@nongnu.org; Wed, 24 Jun 2020 03:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592985057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jop5CGTcNOnfBBL1zdzXGJb92QnzfjFmbAoT3GrCMwE=; b=FdFMNlK3o2by2x5DzdPKzaNvYtiiFWQKJtvx5Dcmyi8ksjUla1UDYl6VUUXdlsBibcWr2r mEjgZRa1xaHO1VU0q/fDSLyvMQtxXOgO2y1t0qJXgwVU7vVWTXO8mLEQyix/QYGODn6RwG avEtpUmTPg4VHpvqnlcVf4jRY/+nogw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-mxLb5ueLPpaOx_vKrsIo0Q-1; Wed, 24 Jun 2020 03:50:55 -0400 X-MC-Unique: mxLb5ueLPpaOx_vKrsIo0Q-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4C482804001; Wed, 24 Jun 2020 07:50:54 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-132.ams2.redhat.com [10.36.112.132]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C875D1C4; Wed, 24 Jun 2020 07:50:46 +0000 (UTC) Subject: Re: [PATCH] fuzz: fix broken qtest check at rcu_disable_atfork To: Alexander Bulekov , qemu-devel@nongnu.org References: <20200618160516.2817-1-alxndr@bu.edu> From: Thomas Huth Message-ID: <55eae4cc-07fb-30d4-b8b6-1cb6499fd2d7@redhat.com> Date: Wed, 24 Jun 2020 09:50:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200618160516.2817-1-alxndr@bu.edu> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/06/24 01:59:40 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Bandan Das , f4bug@amsat.org, Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 18/06/2020 18.05, Alexander Bulekov wrote: > The qtest_enabled check introduced in d6919e4 always returns false, as > it is called prior to configure_accelerators(). Instead of trying to > skip rcu_disable_atfork in qemu_main, simply call rcu_enable_atfork in > the fuzzer, after qemu_main returns. > > Reported-by: Thomas Huth > Signed-off-by: Alexander Bulekov > --- > softmmu/vl.c | 12 +----------- > tests/qtest/fuzz/fuzz.c | 3 +++ > 2 files changed, 4 insertions(+), 11 deletions(-) Thanks, queued to qtest-next now: https://gitlab.com/huth/qemu/-/commits/qtest-next/ Thomas