From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/9] hw/char/pl011: Simplify a bit pl011_can_receive()
Date: Sun, 23 Feb 2025 09:45:30 -0800 [thread overview]
Message-ID: <55ec65da-9027-4ba3-bf89-85cc134e30aa@linaro.org> (raw)
In-Reply-To: <20250220092903.3726-3-philmd@linaro.org>
On 2/20/25 01:28, Philippe Mathieu-Daudé wrote:
> Introduce 'fifo_depth' and 'fifo_available' local variables
> to better express the 'r' variable use.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Luc Michel <luc.michel@amd.com>
> ---
> hw/char/pl011.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
> diff --git a/hw/char/pl011.c b/hw/char/pl011.c
> index 12a2d4bc7bd..5bb83c54216 100644
> --- a/hw/char/pl011.c
> +++ b/hw/char/pl011.c
> @@ -486,7 +486,9 @@ static void pl011_write(void *opaque, hwaddr offset,
> static int pl011_can_receive(void *opaque)
> {
> PL011State *s = (PL011State *)opaque;
> - int r;
> + unsigned fifo_depth = pl011_get_fifo_depth(s);
> + unsigned fifo_available = fifo_depth - s->read_count;
> + int r = fifo_available ? 1 : 0;
This is begging for a bool, though. Both in the local and the return type.
r~
next prev parent reply other threads:[~2025-02-23 17:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 9:28 [PATCH v2 0/9] hw/char: Improve RX FIFO depth uses Philippe Mathieu-Daudé
2025-02-20 9:28 ` [PATCH v2 1/9] hw/char/pl011: Warn when using disabled receiver Philippe Mathieu-Daudé
2025-02-20 9:52 ` Luc Michel
2025-02-20 9:28 ` [PATCH v2 2/9] hw/char/pl011: Simplify a bit pl011_can_receive() Philippe Mathieu-Daudé
2025-02-23 17:45 ` Richard Henderson [this message]
2025-02-20 9:28 ` [PATCH v2 3/9] hw/char/pl011: Improve RX flow tracing events Philippe Mathieu-Daudé
2025-02-23 17:49 ` Richard Henderson
2025-02-20 9:28 ` [PATCH v2 4/9] hw/char/pl011: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-23 18:02 ` Richard Henderson
2025-02-20 9:28 ` [PATCH v2 5/9] hw/char/bcm2835_aux: " Philippe Mathieu-Daudé
2025-02-23 18:02 ` Richard Henderson
2025-02-20 9:28 ` [PATCH v2 6/9] hw/char/imx_serial: " Philippe Mathieu-Daudé
2025-02-23 18:03 ` Richard Henderson
2025-02-24 11:04 ` Bernhard Beschow
2025-02-20 9:29 ` [PATCH v2 7/9] hw/char/mcf_uart: Use FIFO_DEPTH definition instead of magic values Philippe Mathieu-Daudé
2025-02-21 10:10 ` Thomas Huth
2025-02-23 18:04 ` Richard Henderson
2025-02-20 9:29 ` [PATCH v2 8/9] hw/char/mcf_uart: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-22 9:41 ` Thomas Huth
2025-02-23 18:04 ` Richard Henderson
2025-02-20 9:29 ` [PATCH v2 9/9] hw/char/sh_serial: Return correct number of empty RX FIFO elements Philippe Mathieu-Daudé
2025-02-23 18:07 ` Richard Henderson
2025-03-03 12:38 ` [PATCH v2 0/9] hw/char: Improve RX FIFO depth uses Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55ec65da-9027-4ba3-bf89-85cc134e30aa@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).