From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32943)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1c2aMN-0000HK-SY
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:00:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1c2aMK-0006Aw-68
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:00:27 -0400
Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:34085)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <paolo.bonzini@gmail.com>)
	id 1c2aMJ-00069t-Vt
	for qemu-devel@nongnu.org; Fri, 04 Nov 2016 05:00:24 -0400
Received: by mail-wm0-x241.google.com with SMTP id p190so2835270wmp.1
	for <qemu-devel@nongnu.org>; Fri, 04 Nov 2016 02:00:23 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1478194258-75276-1-git-send-email-julian@codesourcery.com>
	<1478194258-75276-4-git-send-email-julian@codesourcery.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55f516cd-7050-1e4a-139c-84012418c683@redhat.com>
Date: Fri, 4 Nov 2016 10:00:19 +0100
MIME-Version: 1.0
In-Reply-To: <1478194258-75276-4-git-send-email-julian@codesourcery.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/5] Fix arm_semi_flen_cb for BE32 system
 mode.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Julian Brown <julian@codesourcery.com>, qemu-devel@nongnu.org



On 03/11/2016 18:30, Julian Brown wrote:
> +#ifdef CONFIG_USER_ONLY
>      size = be32_to_cpu(size);
> +#else
> +    /* If we're running in BE32 system mode, we don't need to do an explicit
> +     * byte swap, because (I think) target memory is already stored in
> +     * byte-swapped format.

Isn't this true also of user-mode (both BE8 and BE32)?

Paolo

> +     */
> +    if (!arm_sctlr_b(env)) {
> +        size = be32_to_cpu(size);
> +    }
> +#endif