From: Denis Plotnikov <dplotnikov@virtuozzo.com>
To: Alberto Garcia <berto@igalia.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, armbru@redhat.com,
qemu-block@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH v8 3/4] qcow2: add zstd cluster compression
Date: Mon, 23 Mar 2020 15:55:02 +0300 [thread overview]
Message-ID: <55f6d94f-100c-fd7f-dbb8-d0b3014017a7@virtuozzo.com> (raw)
In-Reply-To: <w51369z8cg7.fsf@maestria.local.igalia.com>
On 23.03.2020 15:47, Alberto Garcia wrote:
> On Mon 23 Mar 2020 11:20:42 AM CET, Denis Plotnikov wrote:
>>> But consider corrupted image: it may contain any data. And we should
>>> not crash because of it. So, we should return error here.
>> If the image is corrupted we can't continue anyway. If we return -EIO
>> on this condition, we need to do some work investigating what has
>> happened.
> Cannot you just mark the image as corrupted and return -EIO ? I also
> don't think that we should crash QEMU because of malformed input data.
>
> Berto
ok, will return -EIO
next prev parent reply other threads:[~2020-03-23 12:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 14:34 [PATCH v8 0/4] qcow2: Implement zstd cluster compression method Denis Plotnikov
2020-03-21 14:34 ` [PATCH v8 1/4] qcow2: introduce compression type feature Denis Plotnikov
2020-03-23 8:00 ` Vladimir Sementsov-Ogievskiy
2020-03-23 12:22 ` Denis Plotnikov
2020-03-23 12:26 ` Vladimir Sementsov-Ogievskiy
2020-03-23 12:30 ` Denis Plotnikov
2020-03-21 14:34 ` [PATCH v8 2/4] qcow2: rework the cluster compression routine Denis Plotnikov
2020-03-21 14:34 ` [PATCH v8 3/4] qcow2: add zstd cluster compression Denis Plotnikov
2020-03-23 8:44 ` Vladimir Sementsov-Ogievskiy
2020-03-23 10:20 ` Denis Plotnikov
2020-03-23 12:05 ` Vladimir Sementsov-Ogievskiy
2020-03-23 12:47 ` Alberto Garcia
2020-03-23 12:55 ` Denis Plotnikov [this message]
2020-03-21 14:34 ` [PATCH v8 4/4] iotests: 287: add qcow2 compression type test Denis Plotnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f6d94f-100c-fd7f-dbb8-d0b3014017a7@virtuozzo.com \
--to=dplotnikov@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).