From: Jan Kiszka <jan.kiszka@siemens.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>
Cc: "Bin Meng" <bmeng.cn@gmail.com>,
qemu-block@nongnu.org,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Jan Lübbe" <jlu@pengutronix.de>,
"Jerome Forissier" <jerome.forissier@linaro.org>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH v5 5/6] scripts: Add helper script to generate eMMC block device images
Date: Tue, 4 Nov 2025 13:40:14 +0100 [thread overview]
Message-ID: <55f73b5c-a4c5-463b-a507-6617ebde67b0@siemens.com> (raw)
In-Reply-To: <dcb21299-f6b1-489b-b952-aafd64dba31a@linaro.org>
On 04.11.25 13:33, Philippe Mathieu-Daudé wrote:
> On 4/11/25 10:26, Jan Kiszka wrote:
>> On 04.11.25 07:30, Jan Kiszka wrote:
>>> On 03.11.25 14:12, Philippe Mathieu-Daudé wrote:
>>>> Hi Jan,
>>>>
>>>> On 17/10/25 14:03, Jan Kiszka wrote:
>>>>> From: Jan Kiszka <jan.kiszka@siemens.com>
>
>
>>>>> +if [ "$bootsz" -gt $((32640 * 1024)) ]; then
>>>>
>>>> Running on macOS:
>>>>
>>>> scripts/mkemmc.sh: line 165: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 169: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 179: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 191: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 200: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 202: [: : integer expression expected
>>>> scripts/mkemmc.sh: line 204: [: : integer expression expected
>>>>
>>>> $ sh --version
>>>> GNU bash, version 3.2.57(1)-release (arm64-apple-darwin24)
>>>>
>>>> When using dash:
>>>>
>>>> scripts/mkemmc.sh: 165: [: Illegal number:
>>>> scripts/mkemmc.sh: 169: [: Illegal number:
>>>> scripts/mkemmc.sh: 179: [: Illegal number:
>>>> scripts/mkemmc.sh: 191: [: Illegal number:
>>>> scripts/mkemmc.sh: 200: [: Illegal number:
>>>> scripts/mkemmc.sh: 202: [: Illegal number:
>>>> scripts/mkemmc.sh: 204: [: Illegal number:
>>>>
>>>> Should we replace s/[/[[/?
>>>
>>> No, that would be invalid outside of bash. There must be a logical
>>> error.
>>>
>>> How did you invoke the script? What was the value of bootsz then?
>>>
>>
>> I tried with dash from debian trixie, and there is no issue like yours
>> visible.
>>
>> What problem could macOS have here? Will need your help, don't have
>> anything mac-like around right now.
>
> Don't worry, we can merge v6 code part, and add the script / doc
> during the freeze period.
I will send out v6 then. It passed local testing, and I addressed some
further details.
A colleague with a Mac offered to have look tomorrow on this. It is
always a pain there regarding the subtle differences...
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
next prev parent reply other threads:[~2025-11-04 12:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 12:03 [PATCH v5 0/6] sd: Add RPMB emulation to eMMC model Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 1/6] hw/sd/sdcard: Fix size check for backing block image Jan Kiszka
2025-10-20 7:29 ` Cédric Le Goater
2025-10-30 22:10 ` Philippe Mathieu-Daudé
2025-10-17 12:03 ` [PATCH v5 2/6] hw/sd/sdcard: Allow user-instantiated eMMC Jan Kiszka
2025-10-27 11:55 ` Daniel P. Berrangé
2025-10-27 12:23 ` Philippe Mathieu-Daudé
2025-10-27 12:35 ` Daniel P. Berrangé
2025-10-27 12:44 ` Philippe Mathieu-Daudé
2025-10-30 14:17 ` Jan Lübbe
2025-10-27 12:45 ` Jan Lübbe
2025-10-30 16:50 ` Jan Lübbe
2025-10-30 18:10 ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 3/6] hw/sd/sdcard: Add basic support for RPMB partition Jan Kiszka
2025-11-03 15:08 ` Philippe Mathieu-Daudé
2025-11-04 6:34 ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 4/6] hw/sd/sdcard: Handle RPMB MAC field Jan Kiszka
2025-11-03 15:18 ` Philippe Mathieu-Daudé
2025-11-04 6:43 ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 5/6] scripts: Add helper script to generate eMMC block device images Jan Kiszka
2025-11-03 13:12 ` Philippe Mathieu-Daudé
2025-11-04 6:30 ` Jan Kiszka
2025-11-04 9:26 ` Jan Kiszka
2025-11-04 12:33 ` Philippe Mathieu-Daudé
2025-11-04 12:40 ` Jan Kiszka [this message]
2025-11-04 14:14 ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 6/6] docs: Add eMMC device model description Jan Kiszka
2025-11-03 13:15 ` Philippe Mathieu-Daudé
2025-10-20 7:28 ` [PATCH v5 0/6] sd: Add RPMB emulation to eMMC model Cédric Le Goater
2025-10-27 11:15 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55f73b5c-a4c5-463b-a507-6617ebde67b0@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=alex.bennee@linaro.org \
--cc=bmeng.cn@gmail.com \
--cc=eblake@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jerome.forissier@linaro.org \
--cc=jlu@pengutronix.de \
--cc=philmd@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).