From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze9aN-0007w3-Hg for qemu-devel@nongnu.org; Mon, 21 Sep 2015 18:29:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ze9aJ-0006iO-Hk for qemu-devel@nongnu.org; Mon, 21 Sep 2015 18:29:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze9aJ-0006iK-DS for qemu-devel@nongnu.org; Mon, 21 Sep 2015 18:29:19 -0400 References: <1442297513-7001-1-git-send-email-famz@redhat.com> <1442297513-7001-7-git-send-email-famz@redhat.com> From: John Snow Message-ID: <560084BD.6010407@redhat.com> Date: Mon, 21 Sep 2015 18:29:17 -0400 MIME-Version: 1.0 In-Reply-To: <1442297513-7001-7-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , vsementsov@parallels.com, stefanha@redhat.com, Max Reitz On 09/15/2015 02:11 AM, Fam Zheng wrote: > Reviewed-by: Max Reitz > Signed-off-by: Fam Zheng > --- > include/block/blockjob.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/include/block/blockjob.h b/include/block/blockjob.h > index 3e7ad21..a7b497c 100644 > --- a/include/block/blockjob.h > +++ b/include/block/blockjob.h > @@ -50,6 +50,24 @@ typedef struct BlockJobDriver { > * manually. > */ > void (*complete)(BlockJob *job, Error **errp); > + > + /** > + * If the callback is not NULL, it will be invoked when all the jobs > + * belonging to the same transaction complete; or upon this job's > + * completion if it is not in a transaction. Skipped if NULL. > + * > + * Exactly one of .commit() and .abort() will be called for each job. > + */ > + void (*commit)(BlockJob *job); > + I find this phrasing strange, but maybe it's just me. "Exactly one of commit and abort will be called for each job" implies [to me] that it'd be possible to call commit for one, but abort for different jobs [in a transaction] -- but clearly we don't mean that. It is the "for each job" that implies an iteration over a collection to me. Just above we say "[commit] will be invoked when all the jobs belonging to the same transaction are complete" which itself implies either all jobs will be committed or all jobs will be aborted. Maybe: "All jobs will complete with a call to either .commit() or .abort() but never both." But I might be being too bikesheddy. > + /** > + * If the callback is not NULL, it will be invoked when any job in the > + * same transaction fails; or upon this job's failure (due to error or > + * cancellation) if it is not in a transaction. Skipped if NULL. > + * > + * Exactly one of .commit() and .abort() will be called for each job. > + */ > + void (*abort)(BlockJob *job); > } BlockJobDriver; > > /** > I'm probably just too picky. Reviewed-by: John Snow