From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeK5j-0006wi-2W
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 05:42:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeK5e-0007Jr-Gd
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 05:42:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60796)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeK5e-0007Ji-Ag
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 05:42:22 -0400
References: <1442405768-23019-1-git-send-email-yanghy@cn.fujitsu.com>
	<1442405768-23019-5-git-send-email-yanghy@cn.fujitsu.com>
	<56010391.4070806@redhat.com> <560106C2.5080607@cn.fujitsu.com>
	<56010DEF.1050501@redhat.com> <56010F8F.6030006@cn.fujitsu.com>
	<56011D0A.3080607@redhat.com> <56011ECB.3070609@cn.fujitsu.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56012276.80609@redhat.com>
Date: Tue, 22 Sep 2015 17:42:14 +0800
MIME-Version: 1.0
In-Reply-To: <56011ECB.3070609@cn.fujitsu.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 04/12] net: merge qemu_deliver_packet
 and qemu_deliver_packet_iov
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: lizhijian@cn.fujitsu.com, thuth@redhat.com, armbru@redhat.com, stefanha@redhat.com, zhang.zhanghailiang@huawei.com



On 09/22/2015 05:26 PM, Yang Hongyang wrote:
> On 09/22/2015 05:19 PM, Jason Wang wrote:
> [...]
>>>>>
>>>>> If we drop this patch, we will need to introduce 2 deliver func,
>>>>> which
>>>>> seems not clean and simple.
>>>>
>>>> Then you can probably skip the iov_to_buf() if iov_cnt is one in the
>>>> above code?
>>>
>>> Seems like a good idea to avoid the extra memcpy, thank you! BTW,
>>> can I do this on top of the series if there's no other comments?
>>
>> Better squash the changes in this patch or another independent patch
>> before this patch. (We don't want to break bisection).
>>
>>> so that the first 10 patch can be merged as is. if not, I will send
>>> another
>>> version v12 to fix this.
>>
>> Post V12 or if you wish, I can fix this myself :)
>
> It's great if you can fix this, then I can focus on the multiqueue
> support later, thanks a lot for the help! :)

Ok, will do.