From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50483)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZeLPD-0001yK-HK
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 07:06:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZeLPA-0004r7-AQ
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 07:06:39 -0400
Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:34464)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZeLPA-0004qp-2J
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 07:06:36 -0400
Received: by wicfx3 with SMTP id fx3so186265999wic.1
	for <qemu-devel@nongnu.org>; Tue, 22 Sep 2015 04:06:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1440934175-9971-1-git-send-email-marcandre.lureau@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56013637.3070602@redhat.com>
Date: Tue, 22 Sep 2015 13:06:31 +0200
MIME-Version: 1.0
In-Reply-To: <1440934175-9971-1-git-send-email-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone
	project
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org



On 30/08/2015 13:29, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> As previously discussed in the thread "libcacard: use the library?",
> make libcacard a standalone library and use it if --enable-smartcard.
> 
> I made the following repo out of a qemu filter-branch and added autofoo
> build-sys: https://github.com/elmarco/libcacard. Since the original qemu
> git tags are there, I think the first release version should be v2.5,
> but there is no need to follow the same versions as qemu later on.
> 
> libcacard could use the same infrastructure as the qemu project (mailing
> list, git server, reviews etc). I have some experience with libcacard,
> and I would be willing to maintain it, however I don't expect to do
> more development with it in the near future.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

I tested I could build QEMU with smartcard support after installing
Fedora's libcacard-devel from QEMU 2.4, and "ldd" points to
/lib64/libcacard.so.0.

So, at least for Fedora users, there is no dependency on the distro
packaging the new standalone libcacard.

Just a small nit:

diff --git a/configure b/configure
index 6eb553c..0cb88c4 100755
--- a/configure
+++ b/configure
@@ -3863,11 +3863,12 @@ if test "$smartcard" != "no"; then
         libcacard_libs=$($pkg_config --libs libcacard)
         QEMU_CFLAGS="$QEMU_CFLAGS $libcacard_cflags"
         libs_softmmu="$libs_softmmu $libcacard_libs"
+        smartcard="yes"
     else
-        if test "$libcacard" = "yes"; then
-            feature_not_found "libcacard" "Install libcacard devel"
+        if test "$smartcard" = "yes"; then
+            feature_not_found "smartcard" "Install libcacard-devel"
         fi
-        libcacard="no"
+        smartcard="no"
     fi
 fi

Paolo