From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeMXp-0003az-Fv for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:19:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeMXm-0005SU-DP for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:19:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeMXm-0005SM-7s for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:19:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id CAE36461D2 for ; Tue, 22 Sep 2015 12:19:33 +0000 (UTC) References: <1442582350-9179-1-git-send-email-berrange@redhat.com> <1442582350-9179-8-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <5601474F.2000507@redhat.com> Date: Tue, 22 Sep 2015 14:19:27 +0200 MIME-Version: 1.0 In-Reply-To: <1442582350-9179-8-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 07/16] io: add abstract QIOChannel classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , Gerd Hoffmann On 18/09/2015 15:19, Daniel P. Berrange wrote: > + QIO_CHANNEL_FEATURE_FD_PASS = (1 << 0), > + QIO_CHANNEL_FEATURE_SHUTDOWN = (1 << 1), > + QIO_CHANNEL_FEATURE_DELAY = (1 << 2), > + QIO_CHANNEL_FEATURE_CORK = (1 << 3), TCP_NODELAY and TCP_CORK are just hints; I think it is okay to just ignore them if not supported. You obviously disagree, so the question is why? :) Paolo