From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZeMbb-00075H-BH
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:23:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZeMbY-00087e-8A
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:23:31 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZeMbY-00087Y-1M
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 08:23:28 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 6A7BAA3059
	for <qemu-devel@nongnu.org>; Tue, 22 Sep 2015 12:23:27 +0000 (UTC)
References: <1442582350-9179-1-git-send-email-berrange@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <56014838.6020109@redhat.com>
Date: Tue, 22 Sep 2015 14:23:20 +0200
MIME-Version: 1.0
In-Reply-To: <1442582350-9179-1-git-send-email-berrange@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>



On 18/09/2015 15:18, Daniel P. Berrange wrote:
> David Gilbert had some feedback on my previous RFC series which
> I have incorporated into this new posting. I did forget his
> comments about using #defines instead of magic constants in
> the websock patch, so that's still on my todo list.
>=20
> Finally I've listed myself as maintainer for the new io/ and
> include/io/ directory prefixes.

I only made a few very small remarks.  The API is reasonable and you've
proved its utility by using it in the rest of your project.

I remember I had some remarks about the rest of the conversion and
especially the integration with coroutines, but it's not part of this
series.

Paolo