From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeNPo-00017X-He for qemu-devel@nongnu.org; Tue, 22 Sep 2015 09:15:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeNPj-0008Ex-GB for qemu-devel@nongnu.org; Tue, 22 Sep 2015 09:15:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeNPj-0008Ej-Bb for qemu-devel@nongnu.org; Tue, 22 Sep 2015 09:15:19 -0400 References: <20150917162322.8676.29314.stgit@PASHA-ISP.def.inno> <20150917162427.8676.36558.stgit@PASHA-ISP.def.inno> From: Paolo Bonzini Message-ID: <5601545E.9090000@redhat.com> Date: Tue, 22 Sep 2015 15:15:10 +0200 MIME-Version: 1.0 In-Reply-To: <20150917162427.8676.36558.stgit@PASHA-ISP.def.inno> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v18 11/21] replay: recording and replaying clock ticks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: edgar.iglesias@xilinx.com, peter.maydell@linaro.org, igor.rubinov@gmail.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, hines@cert.org, fred.konrad@greensocs.com On 17/09/2015 18:24, Pavel Dovgalyuk wrote: > + if ((now < last || now > (last + get_max_clock_jump())) > + && replay_mode == REPLAY_MODE_NONE) { > notifier_list_notify(&clock->reset_notifiers, &now); This seems wrong. You will have different timers in the record and the replay if you do not invoke e.g. rtc_notify_clock_reset. Paolo