From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49764)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1ZeOJp-0005Kx-6n
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:13:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1ZeOJj-0001J5-LR
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:13:17 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:25038)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1ZeOJj-0001IS-Cj
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:13:11 -0400
References: <1442333283-13119-1-git-send-email-marcandre.lureau@redhat.com>
	<1442333283-13119-15-git-send-email-marcandre.lureau@redhat.com>
From: Claudio Fontana <claudio.fontana@huawei.com>
Message-ID: <560161F0.8050902@huawei.com>
Date: Tue, 22 Sep 2015 16:13:04 +0200
MIME-Version: 1.0
In-Reply-To: <1442333283-13119-15-git-send-email-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 14/46] ivshmem: remove useless
 ivshmem_update_irq() val argument
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com

On 15.09.2015 18:07, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> val isn't used in ivshmem_update_irq() function.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  hw/misc/ivshmem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index e890967..3398a57 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -123,7 +123,7 @@ static inline bool is_power_of_two(uint64_t x) {
>  }
>  
>  /* accessing registers - based on rtl8139 */
> -static void ivshmem_update_irq(IVShmemState *s, int val)
> +static void ivshmem_update_irq(IVShmemState *s)
>  {
>      PCIDevice *d = PCI_DEVICE(s);
>      int isr;
> @@ -144,7 +144,7 @@ static void ivshmem_IntrMask_write(IVShmemState *s, uint32_t val)
>  
>      s->intrmask = val;
>  
> -    ivshmem_update_irq(s, val);
> +    ivshmem_update_irq(s);
>  }
>  
>  static uint32_t ivshmem_IntrMask_read(IVShmemState *s)
> @@ -162,7 +162,7 @@ static void ivshmem_IntrStatus_write(IVShmemState *s, uint32_t val)
>  
>      s->intrstatus = val;
>  
> -    ivshmem_update_irq(s, val);
> +    ivshmem_update_irq(s);
>  }
>  
>  static uint32_t ivshmem_IntrStatus_read(IVShmemState *s)
> @@ -172,7 +172,7 @@ static uint32_t ivshmem_IntrStatus_read(IVShmemState *s)
>      /* reading ISR clears all interrupts */
>      s->intrstatus = 0;
>  
> -    ivshmem_update_irq(s, 0);
> +    ivshmem_update_irq(s);
>  
>      return ret;
>  }
> 


Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>