From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeOqb-0004F2-Io for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeOqY-0008K1-Oe for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:47:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeOqY-0008Jt-H6 for qemu-devel@nongnu.org; Tue, 22 Sep 2015 10:47:06 -0400 References: <1442588324-11365-1-git-send-email-yuanhan.liu@linux.intel.com> <1442588324-11365-8-git-send-email-yuanhan.liu@linux.intel.com> From: Eric Blake Message-ID: <560169E8.6020006@redhat.com> Date: Tue, 22 Sep 2015 08:47:04 -0600 MIME-Version: 1.0 In-Reply-To: <1442588324-11365-8-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kdQlfEPqpO7KO5qumfem8UR2skjR5eKv0" Subject: Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuanhan Liu , qemu-devel@nongnu.org Cc: jasowang@redhat.com, mst@redhat.com, Changchun.ouyang@hotmail.com, Changchun Ouyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kdQlfEPqpO7KO5qumfem8UR2skjR5eKv0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/18/2015 08:58 AM, Yuanhan Liu wrote: > From: Changchun Ouyang >=20 > Add a new message, VHOST_USER_SET_VRING_ENABLE, to enable or disable > a specific virt queue, which is similar to attach/detach queue for > tap device. >=20 > virtio driver on guest doesn't have to use max virt queue pair, it > could enable any number of virt queue ranging from 1 to max virt > queue pair. >=20 > Signed-off-by: Changchun Ouyang > Signed-off-by: Yuanhan Liu > --- > docs/specs/vhost-user.txt | 12 +++++++++++- > hw/net/vhost_net.c | 18 ++++++++++++++++++ > hw/net/virtio-net.c | 8 ++++++++ > hw/virtio/vhost-user.c | 19 +++++++++++++++++++ > include/hw/virtio/vhost-backend.h | 2 ++ > include/net/vhost_net.h | 2 ++ > 6 files changed, 60 insertions(+), 1 deletion(-) >=20 > diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt > index cfc9d41..a5f1c31 100644 > --- a/docs/specs/vhost-user.txt > +++ b/docs/specs/vhost-user.txt > @@ -148,7 +148,9 @@ VHOST_USER_GET_PROTOCOL_FEATURES. Master should sto= p when the number of > requested queues is bigger than that. > =20 > As all queues share one connection, the master uses a unique index for= each > -queue in the sent message to identify a specified queue. > +queue in the sent message to identify a specified queue. One queue pai= rs s/pairs/pair/ > +is enabled initially. More queues are enabled dynamically, by sending > +message VHOST_USER_SET_VRING_ENABLE. > =20 > Message types > ------------- > @@ -327,3 +329,11 @@ Message types > Query how many queues the backend supports. This request should = be > sent only when VHOST_USER_PROTOCOL_F_MQ is set in quried protoco= l > features by VHOST_USER_GET_PROTOCOL_FEATURES. > + > + * VHOST_USER_SET_VRING_ENABLE > + > + Id: 18 > + Equivalent ioctl: N/A > + Master payload: vring state description > + > + Signal slave to enable or disable corresponding vring. Does there need to be any QMP control to manually change a given queue, or is it all used under the hood with no need for management apps to care other than their initial request of max queues? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kdQlfEPqpO7KO5qumfem8UR2skjR5eKv0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWAWnoAAoJEKeha0olJ0NqcQwIAIJen5g6rbSX8vXuJta6K2NB XNfpvB4g4WJHfutTl5juft1b8d9vCLrbnIfjunM7zAccrfiWDAC5T8HZ4HXz0HeZ SCJGmpFP9TOOLR5kvrltYPoPvG3DXjYymASBhcj/v822R3IthTSKh76DvN/B7KiO 0XUArJuxl15fWATx9SYAgC8dhg3NUMpEeBvrvxLPD1Ja6VaWQ/G3SEfCtmVALq2l 2k6LtX8m69nR9neiXhU5KCza5LNreiJxi7agcQOWIVG0FddJYQGn10TKlXcikiWC 02+9RUti95YmDn1FhpCTqSPOXYiksjMyo/B38aoK9pki48ve+gPjPPKaYiT7S4A= =UkoX -----END PGP SIGNATURE----- --kdQlfEPqpO7KO5qumfem8UR2skjR5eKv0--