From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeQy0-0000bT-7y for qemu-devel@nongnu.org; Tue, 22 Sep 2015 13:02:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeQxz-0003Vq-Ae for qemu-devel@nongnu.org; Tue, 22 Sep 2015 13:02:56 -0400 References: <1442582574-14275-1-git-send-email-armbru@redhat.com> <1442582574-14275-3-git-send-email-armbru@redhat.com> <20150922152313.GK3999@noname.str.redhat.com> From: Eric Blake Message-ID: <560189B3.6060602@redhat.com> Date: Tue, 22 Sep 2015 11:02:43 -0600 MIME-Version: 1.0 In-Reply-To: <20150922152313.GK3999@noname.str.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gVlrF463qaBCDPjXiUd5IwePK2F8XA3d6" Subject: Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Markus Armbruster Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gVlrF463qaBCDPjXiUd5IwePK2F8XA3d6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2015 09:23 AM, Kevin Wolf wrote: > Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben: >> From: Eric Blake >> >> Commits 7216ae3d and d2828429 disabled some error message hints, >> all because a change to use modern error reporting meant that the >> hint would be output prior to the actual error. Fix this by making >> hints a first-class member of Error. >> >> For example, we are now back to the pleasant: >> >> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=3D, >> qemu-system-x86_64: --chardev null,id=3D,: Parameter 'id' expects an = identifier >> Identifiers consist of letters, digits, '-', '.', '_', starting with = a letter. >> >> Signed-off-by: Eric Blake >> Reviewed-by: Paolo Bonzini >> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com> >> Signed-off-by: Markus Armbruster >=20 > This broke qemu-iotests 049. Can you please send a patch to update the > reference output? Will do (and I guess I should run qemu-iotests more frequently. Does 'make check' suffice, or is there other magic involved?) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gVlrF463qaBCDPjXiUd5IwePK2F8XA3d6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWAYmzAAoJEKeha0olJ0Nq1jMIAJYiEcmqTEtv2Wzggc+yPDZI 6+NA3uEz2JADmUTP0gZ4AYw6VuibGa36AsFmUZLPXrU22mItd5+OJoJADIX/SWUn DD79Pcdsh1u1nulx7uPubtc8fXOfrAH6nZdPkCnZebThVnyILkRyw9olF2jhX8Og mjP6o26i9AJuJLlCnC6H9i6Fj4htdBADlOMAn63rEvWHRU7+5Lbtzb9XD0w49NoN gv5Mlttr10T78wUUICjeppYUSVFo0e5g2AEnZvXomylm21P4v9WZw/6+5jdf5C2Z UvIBqmMFi5/XYASvWphY7455+XfEE8aGXR7t5HYJ+sE8GAUBCxiLpJ5edhY6JZo= =SBPR -----END PGP SIGNATURE----- --gVlrF463qaBCDPjXiUd5IwePK2F8XA3d6--