From: Laszlo Ersek <lersek@redhat.com>
To: Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design
Date: Tue, 22 Sep 2015 21:01:35 +0200 [thread overview]
Message-ID: <5601A58F.9020009@redhat.com> (raw)
In-Reply-To: <5601A34A.3050606@redhat.com>
On 09/22/15 20:51, Eric Blake wrote:
> On 09/22/2015 12:28 PM, Laszlo Ersek wrote:
>> meta review of your review:
>>
>
>>
>>>> +Each system/userspace emulation target needs to have a slightly
>>>> +different set of make rules / variables. Thus, make will be recursively
>>>> +invoked for each of the emulation targets.
>>>> +
>>>> +The recursive invokation will end up processing the toplevel
>>>
>>> invocation again.
>>
>> Self-contradictory period again! :)
>>
>>> Thanks for writing this!
>
> Heartily seconded - in spite of our review comments, the document looks
> very useful.
>
>>
>> Yes!
>>
>>> Pretending to be Eric,
>>
>> Yes. :)
>
> Don't know if I should be pleased or shocked :)
Pleased, certainly. :)
Laszlo
next prev parent reply other threads:[~2015-09-22 19:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 16:35 [Qemu-devel] [PATCH] docs: describe the QEMU build system structure / design Daniel P. Berrange
2015-09-22 18:11 ` John Snow
2015-09-22 18:28 ` Laszlo Ersek
2015-09-22 18:51 ` Eric Blake
2015-09-22 19:01 ` Laszlo Ersek [this message]
2015-09-22 19:47 ` Paolo Bonzini
2015-09-22 18:21 ` Laszlo Ersek
2015-09-22 18:22 ` Eric Blake
2015-09-23 8:35 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5601A58F.9020009@redhat.com \
--to=lersek@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).