From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZeSov-0004e7-Uo
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 15:01:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZeSos-0002kb-PW
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 15:01:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:43009)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZeSos-0002kO-L7
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 15:01:38 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id EA6C6A37E2
	for <qemu-devel@nongnu.org>; Tue, 22 Sep 2015 19:01:37 +0000 (UTC)
References: <1442939759-9862-1-git-send-email-berrange@redhat.com>
	<560199E7.6020401@redhat.com> <56019DB9.3020804@redhat.com>
	<5601A34A.3050606@redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <5601A58F.9020009@redhat.com>
Date: Tue, 22 Sep 2015 21:01:35 +0200
MIME-Version: 1.0
In-Reply-To: <5601A34A.3050606@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] docs: describe the QEMU build system
 structure / design
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/22/15 20:51, Eric Blake wrote:
> On 09/22/2015 12:28 PM, Laszlo Ersek wrote:
>> meta review of your review:
>>
> 
>>
>>>> +Each system/userspace emulation target needs to have a slightly
>>>> +different set of make rules / variables. Thus, make will be recursively
>>>> +invoked for each of the emulation targets.
>>>> +
>>>> +The recursive invokation will end up processing the toplevel
>>>
>>> invocation again.
>>
>> Self-contradictory period again! :)
>>
>>> Thanks for writing this!
> 
> Heartily seconded - in spite of our review comments, the document looks
> very useful.
> 
>>
>> Yes!
>>
>>> Pretending to be Eric,
>>
>> Yes. :)
> 
> Don't know if I should be pleased or shocked :)

Pleased, certainly. :)

Laszlo