From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37410) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeU47-0002hh-7h for qemu-devel@nongnu.org; Tue, 22 Sep 2015 16:21:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeU46-0007sP-JH for qemu-devel@nongnu.org; Tue, 22 Sep 2015 16:21:27 -0400 References: <1442952987-20187-1-git-send-email-ehabkost@redhat.com> <1442952987-20187-4-git-send-email-ehabkost@redhat.com> From: Hannes Reinecke Message-ID: <5601B838.30907@suse.de> Date: Tue, 22 Sep 2015 22:21:12 +0200 MIME-Version: 1.0 In-Reply-To: <1442952987-20187-4-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 3/3] megasas: Use qemu_hw_version() instead of QEMU_VERSION List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Paolo Bonzini , Marcel Apfelbaum , Laszlo Ersek , qemu-block@nongnu.org, "Michael S. Tsirkin" On 09/22/2015 10:16 PM, Eduardo Habkost wrote: > Guest visible data shouldn't change with a simple QEMU upgrade, so use > qemu_hw_version() to ensure it won't change (as long as the machine > class being used has hw_version set). >=20 > Cc: Hannes Reinecke > Cc: Paolo Bonzini > Cc: qemu-block@nongnu.org > Signed-off-by: Eduardo Habkost > --- > hw/scsi/megasas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c > index a04369c..e0529b1 100644 > --- a/hw/scsi/megasas.c > +++ b/hw/scsi/megasas.c > @@ -757,7 +757,7 @@ static int megasas_ctrl_get_info(MegasasState *s, M= egasasCmd *cmd) > =20 > memcpy(info.product_name, base_class->product_name, 24); > snprintf(info.serial_number, 32, "%s", s->hba_serial); > - snprintf(info.package_version, 0x60, "%s-QEMU", QEMU_VERSION); > + snprintf(info.package_version, 0x60, "%s-QEMU", qemu_hw_version())= ; > memcpy(info.image_component[0].name, "APP", 3); > snprintf(info.image_component[0].version, 10, "%s-QEMU", > base_class->product_version); >=20 Ah. right. Should be okay, then. Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)