From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZeWZm-0002Vm-OH
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:02:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZeWZl-00047A-Ud
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:02:18 -0400
References: <1442582574-14275-1-git-send-email-armbru@redhat.com>
	<1442582574-14275-3-git-send-email-armbru@redhat.com>
	<20150922152313.GK3999@noname.str.redhat.com>
	<560189B3.6060602@redhat.com>
From: John Snow <jsnow@redhat.com>
Message-ID: <5601DDF2.3060000@redhat.com>
Date: Tue, 22 Sep 2015 19:02:10 -0400
MIME-Version: 1.0
In-Reply-To: <560189B3.6060602@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-block] [PULL 2/8] hmp: Allow for error
 message hints on HMP
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org



On 09/22/2015 01:02 PM, Eric Blake wrote:
> On 09/22/2015 09:23 AM, Kevin Wolf wrote:
>> Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
>>> From: Eric Blake <eblake@redhat.com>
>>>
>>> Commits 7216ae3d and d2828429 disabled some error message hints,
>>> all because a change to use modern error reporting meant that the
>>> hint would be output prior to the actual error.  Fix this by making
>>> hints a first-class member of Error.
>>>
>>> For example, we are now back to the pleasant:
>>>
>>>  $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
>>>  qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier
>>>  Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Message-Id: <1441901956-21991-1-git-send-email-eblake@redhat.com>
>>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
>> This broke qemu-iotests 049. Can you please send a patch to update the
>> reference output?
> 
> Will do (and I guess I should run qemu-iotests more frequently. Does
> 'make check' suffice, or is there other magic involved?)
> 

>>From the build directory:

pushd tests/qemu-iotests;
./check -v -qcow2;
./check -v -raw;
popd

If there is a smarter way of doing it, it is unknown to me.

--js