From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36722)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZeWuM-0007nP-Uu
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:23:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZeWuM-0005wX-4l
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 19:23:34 -0400
References: <1442963752-10950-1-git-send-email-eblake@redhat.com>
From: John Snow <jsnow@redhat.com>
Message-ID: <5601E2EE.8010109@redhat.com>
Date: Tue, 22 Sep 2015 19:23:26 -0400
MIME-Version: 1.0
In-Reply-To: <1442963752-10950-1-git-send-email-eblake@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tests: Fix test 049 fallout from improved
 HMP error messages
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-block@nongnu.org



On 09/22/2015 07:15 PM, Eric Blake wrote:
> Commit 50b7b000 improved HMP error messages, but forgot to update
> qemu-iotests to match.
> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> 
> I'm not sure if this should go through Markus' "error" tree,
> since that's where the break was introduced, or through a
> "block" tree since it touches qemu-iotests.
> 
> And now that I have a recipe for running qemu-iotests, I should
> have no excuse for repeating this type of mistake :)
> 
>  tests/qemu-iotests/049.out | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/049.out b/tests/qemu-iotests/049.out
> index 0425ae0..a2b6703 100644
> --- a/tests/qemu-iotests/049.out
> +++ b/tests/qemu-iotests/049.out
> @@ -118,6 +118,7 @@ qemu-img: kilobytes, megabytes, gigabytes, terabytes, petabytes and exabytes.
> 
>  qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2
>  qemu-img: Parameter 'size' expects a size
> +You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and terabytes.
>  qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'
> 
>  == Check correct interpretation of suffixes for cluster size ==
> 

Grazie,

Reviewed-by: John Snow <jsnow@redhat.com>