From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33348) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeZSe-0002ZX-No for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:07:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeZSa-0006hU-NX for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:07:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeZSa-0006hK-Iq for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:07:04 -0400 References: <1442588324-11365-1-git-send-email-yuanhan.liu@linux.intel.com> <1442588324-11365-8-git-send-email-yuanhan.liu@linux.intel.com> <560169E8.6020006@redhat.com> <20150923020502.GB2339@yliu-dev.sh.intel.com> From: Eric Blake Message-ID: <56020942.10701@redhat.com> Date: Tue, 22 Sep 2015 20:06:58 -0600 MIME-Version: 1.0 In-Reply-To: <20150923020502.GB2339@yliu-dev.sh.intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wAVxUF41iXvimLgDJBk24wktDdObs25j7" Subject: Re: [Qemu-devel] [PATCH v10 7/7] vhost-user: add a new message to disable/enable a specific virt queue. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yuanhan Liu Cc: jasowang@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, Changchun.ouyang@hotmail.com, Changchun Ouyang This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wAVxUF41iXvimLgDJBk24wktDdObs25j7 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2015 08:05 PM, Yuanhan Liu wrote: >>> + * VHOST_USER_SET_VRING_ENABLE >>> + >>> + Id: 18 >>> + Equivalent ioctl: N/A >>> + Master payload: vring state description >>> + >>> + Signal slave to enable or disable corresponding vring. >> >> Does there need to be any QMP control to manually change a given queue= , >> or is it all used under the hood with no need for management apps to >> care other than their initial request of max queues? >=20 > TBH, I don't know. As far as I know, there is only one queue pair will > be enabled by default, and it's user's job to enable (or disable) more > queue pairs, say, by ethtool: >=20 > # ethtool -L eth0 combined >=20 > Which ends up sending the VHOST_USER_SET_VRING_ENABLE to actually enabl= e > (or disable) a specific queue pairs. So if I'm understanding, it is ethtool, not qemu, that is used to turn on additional queues, and therefore we don't need a QMP command in qemu to control things. >=20 > Does that answer your question? I think so, but I'll let other reviewers more familiar with this area of code give a final say. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wAVxUF41iXvimLgDJBk24wktDdObs25j7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWAglCAAoJEKeha0olJ0Nq4FIH/0Pq+SN+AXKVGO7FdnQ2GUZZ 9iD7XXQ/nclpEK145RETPdWgy3sMmq1sn0QZ9Q1us9KPsY2Mg7vhlgWmdhZThrcx ceNpB/lmuBi9BZLUtS+uj59ZNCqsQrRdOJ823VoGg17zlTNTXvxw315En17hZzei hYeCEoRHb5Il+ejRAuEfH0/ObJRfr6T8QJAr4RF/UM0wXx1b0DtPzeolkgsYN5mN pUubgpM6QtLUvnwQFCeSwAqx8Y1t8802Rczzl6ulP14yfJv0jd6CZzIX76JuDXr0 VNkPpGvS2PYf8z/ss3BvitAF6GQQkUWC3T99+ld21HPs/YgyyMXH3iCBtmPkY7w= =ZcWr -----END PGP SIGNATURE----- --wAVxUF41iXvimLgDJBk24wktDdObs25j7--