From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeZYg-0004RB-J4
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:13:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeZYc-0004ib-9s
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:13:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57648)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZeZYc-0004gr-2U
	for qemu-devel@nongnu.org; Tue, 22 Sep 2015 22:13:18 -0400
References: <1442588324-11365-1-git-send-email-yuanhan.liu@linux.intel.com>
	<1442588324-11365-7-git-send-email-yuanhan.liu@linux.intel.com>
	<560129F6.2020704@redhat.com>
	<20150923015741.GA2339@yliu-dev.sh.intel.com>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <56020A7A.8030801@redhat.com>
Date: Wed, 23 Sep 2015 10:12:10 +0800
MIME-Version: 1.0
In-Reply-To: <20150923015741.GA2339@yliu-dev.sh.intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v10 6/7] vhost-user: add multiple queue
	support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: Changchun Ouyang <changchun.ouyang@intel.com>, qemu-devel@nongnu.org, Changchun.ouyang@hotmail.com, mst@redhat.com



On 09/23/2015 09:57 AM, Yuanhan Liu wrote:
> On Tue, Sep 22, 2015 at 06:14:14PM +0800, Jason Wang wrote:
>>
> [...]
>>> -static void net_vhost_link_down(VhostUserState *s, bool link_down)
>>> +static void net_vhost_link_down(int queues, NetClientState *ncs[],
>>> +                                bool link_down)
>>>  {
>>> -    s->nc.link_down = link_down;
>>> +    NetClientState *nc;
>>> +    int i;
>>>  
>>> -    if (s->nc.peer) {
>>> -        s->nc.peer->link_down = link_down;
>>> -    }
>>> +    for (i = 0; i < queues; i++) {
>>> +        nc = ncs[i];
>>>  
>>> -    if (s->nc.info->link_status_changed) {
>>> -        s->nc.info->link_status_changed(&s->nc);
>>> -    }
>>> +        nc->link_down = link_down;
>>> +
>>> +        if (nc->peer) {
>>> +            nc->peer->link_down = link_down;
>>> +        }
>>> +
>>> +        if (nc->info->link_status_changed) {
>>> +            nc->info->link_status_changed(nc);
>>> +        }
>>>  
>>> -    if (s->nc.peer && s->nc.peer->info->link_status_changed) {
>>> -        s->nc.peer->info->link_status_changed(s->nc.peer);
>>> +        if (nc->peer && nc->peer->info->link_status_changed) {
>>> +            nc->peer->info->link_status_changed(nc->peer);
>>> +        }
>>>      }
>>>  }
>> The semantics is a little bit difference with qmp_set_link. What's the
>> reason for this? If there's no specific reason, probably, we could just
>> reuse qmp_set_link() (or part of) here?
> I did this just because I refactored the vhost_user init code, making
> the char dev handler to initiate all ncs. Hence I turned net_vhost_link_down()
> to handle all ncs, just like what I did for vhost_user_start().
>
> And TBH, I'm not aware of qmp_set_link() before, and after reading the
> code, I do think we can simply invoke it instead. And thanks for the
> info.
>
>> Other looks good to me.
> Thanks for the review. May I add your reviewed-by if I fix above issue?
>
> 	--yliu

I prefer to add it myself :)

Thanks.