From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZegW2-0000fv-QV for qemu-devel@nongnu.org; Wed, 23 Sep 2015 05:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZegVz-0002ia-GY for qemu-devel@nongnu.org; Wed, 23 Sep 2015 05:39:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZegVz-0002iT-C8 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 05:39:03 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 1B054C0A146A for ; Wed, 23 Sep 2015 09:39:03 +0000 (UTC) References: <1442836223-282767-1-git-send-email-imammedo@redhat.com> <55FFF67F.5070701@redhat.com> <20150923113644.28c31559@nial.brq.redhat.com> From: Paolo Bonzini Message-ID: <56027330.9010309@redhat.com> Date: Wed, 23 Sep 2015 11:38:56 +0200 MIME-Version: 1.0 In-Reply-To: <20150923113644.28c31559@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pc: memhotplug: rise minimum DIMM addr/size alignment to 128Mb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Peter , ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, David , Jiri On 23/09/2015 11:36, Igor Mammedov wrote: > Also it's QEMU bug/fault and pushing workaround to upper layers > doesn't seem right when it's much easier to do it in QEMU itself. No, it's virtio's bug. It makes sense to push workaround for guest bugs as far from the hypervisor as possible. If we want to increase the alignment in QEMU, I would prefer to have natural alignment which makes some sense and happens to work around the bug as well. Michael, Eduardo, any third opinions? Paolo