From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZehQJ-0006nS-3G for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZehQF-0006fv-Ta for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:37:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZehQF-0006fe-Oq for qemu-devel@nongnu.org; Wed, 23 Sep 2015 06:37:11 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 472012F9125 for ; Wed, 23 Sep 2015 10:37:11 +0000 (UTC) References: <1442952987-20187-1-git-send-email-ehabkost@redhat.com> <20150923100449.036210bc@nial.brq.redhat.com> From: Laszlo Ersek Message-ID: <560280D4.8070609@redhat.com> Date: Wed, 23 Sep 2015 12:37:08 +0200 MIME-Version: 1.0 In-Reply-To: <20150923100449.036210bc@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/3] pc: Set hw_version on all machine classes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Eduardo Habkost Cc: Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Marcel Apfelbaum On 09/23/15 10:04, Igor Mammedov wrote: > On Tue, 22 Sep 2015 17:16:24 -0300 > Eduardo Habkost wrote: > >> In 2012, QEMU had a bug where it exposed QEMU version information >> to the guest, meaning a QEMU upgrade would expose different >> hardware to the guest OS even if the same machine-type is being >> used. >> >> The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4, >> on all machines up to pc-1.0. But we kept introducing the same >> bug on all newer machines since then. That means we are breaking >> guest ABI every time QEMU was upgraded. >> >> Fix this by setting the hw_version on all PC machines, making >> sure the hardware won't change when upgrading QEMU. >> >> This series is based on Michael's PCI tree, plus the "Set >> broken_reserved_end on pc-*-2.4, not 2.5" patch I submitted >> earlier today. > I haven't seen this patch on list, perhaps it needs to be resubmitted? http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg05778.html