From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZejD4-0006Dy-Hd
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 08:31:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZejD1-00020H-CH
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 08:31:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:54691)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZejD1-0001zj-6q
	for qemu-devel@nongnu.org; Wed, 23 Sep 2015 08:31:39 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 69205461EE
	for <qemu-devel@nongnu.org>; Wed, 23 Sep 2015 12:31:38 +0000 (UTC)
References: <1442952987-20187-1-git-send-email-ehabkost@redhat.com>
	<20150923100449.036210bc@nial.brq.redhat.com>
	<560280D4.8070609@redhat.com>
	<20150923134725.1497f055@nial.brq.redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <56029BA7.3040806@redhat.com>
Date: Wed, 23 Sep 2015 14:31:35 +0200
MIME-Version: 1.0
In-Reply-To: <20150923134725.1497f055@nial.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/3] pc: Set hw_version on all machine
 classes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org

On 09/23/15 13:47, Igor Mammedov wrote:
> On Wed, 23 Sep 2015 12:37:08 +0200
> Laszlo Ersek <lersek@redhat.com> wrote:
> 
>> On 09/23/15 10:04, Igor Mammedov wrote:
>>> On Tue, 22 Sep 2015 17:16:24 -0300
>>> Eduardo Habkost <ehabkost@redhat.com> wrote:
>>>
>>>> In 2012, QEMU had a bug where it exposed QEMU version information
>>>> to the guest, meaning a QEMU upgrade would expose different
>>>> hardware to the guest OS even if the same machine-type is being
>>>> used.
>>>>
>>>> The bug was fixed by commit 93bfef4c6e4b23caea9d51e1099d06433d8835a4,
>>>> on all machines up to pc-1.0. But we kept introducing the same
>>>> bug on all newer machines since then. That means we are breaking
>>>> guest ABI every time QEMU was upgraded.
>>>>
>>>> Fix this by setting the hw_version on all PC machines, making
>>>> sure the hardware won't change when upgrading QEMU.
>>>>
>>>> This series is based on Michael's PCI tree, plus the "Set
>>>> broken_reserved_end on pc-*-2.4, not 2.5" patch I submitted
>>>> earlier today.
>>> I haven't seen this patch on list, perhaps it needs to be resubmitted?
>>
>> http://lists.nongnu.org/archive/html/qemu-devel/2015-09/msg05778.html
> If I'm not mistaken it's link to this series and not to
> "Set broken_reserved_end on pc-*-2.4, not 2.5" patch.

Ugh, right. Sorry. I misunderstood what you meant with "this".

Laszlo