From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zekzz-0001Kb-C5 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:26:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zekzw-0005el-7z for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:26:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zekzw-0005e4-2r for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:26:16 -0400 References: <1442872682-6523-1-git-send-email-eblake@redhat.com> <1442872682-6523-2-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <5602B686.4010209@redhat.com> Date: Wed, 23 Sep 2015 08:26:14 -0600 MIME-Version: 1.0 In-Reply-To: <1442872682-6523-2-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wkGn4FMlE2lkbr1wW6OgfliXkuIoHwFin" Subject: Re: [Qemu-devel] [PATCH v5 01/46] qapi: Sort qapi-schema tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, armbru@redhat.com, ehabkost@redhat.com, DirtY.iCE.hu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wkGn4FMlE2lkbr1wW6OgfliXkuIoHwFin Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2015 03:57 PM, Eric Blake wrote: > Recent changes to qapi have provided quite a bit of churn in > the makefile, because we are inconsistent on what order test > names appear in, and on whether to re-wrap the list of tests or > just add arbitrary line lengths. Writing the list in a sorted > fashion, one test per line, will make future patches easier > to see what tests are being added or removed by a patch. >=20 > Signed-off-by: Eric Blake > --- > tests/Makefile | 160 ++++++++++++++++++++++++++++++++++++++++---------= -------- > 1 file changed, 114 insertions(+), 46 deletions(-) >=20 > +qapi-schema +=3D alternate-array.json > +qapi-schema +=3D alternate-base.json Hmm, I just realized we require GNU make, and that we already use $(wildcard) when building up other tests. Would it be worth writing this patch to merely use $(wildcard qapi-tests/*.json)? Then further additions (and removals) of .json files would automatically be picked up without requiring Makefile tweaking. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --wkGn4FMlE2lkbr1wW6OgfliXkuIoHwFin Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWAraGAAoJEKeha0olJ0NqGOAH/08Srto6RRnIH1FJFBQp1ruW 1psgdR9ZRTtwgVy1NW7bwpeM+2sKj7QN7rji5EHwBHxGu3w+OVuuyNXBk1FBw4FQ yxdduifVZBZL7hwpCoB9k6igKxafIjDoXG2uv28bXv+GcdscKbgBhm0Zs/UfVapf xPP8fct1023blv41i9/8JtmvDgx+l/5hW+418IIEs872XrPh7Y7clcNWTr8DTnuM fYbzs8Yxtrvfph+hXUU9R3M+ATaO79Bc97DgT4tjgkl6nf9CBdZdZc+4pNlDsaUx XgtQhQPvoJ8paXGVHDgn5Ze0P3i+GAU1bzLsU4CppeWfdgBHWOqy+sTGneeGZj0= =Y5HP -----END PGP SIGNATURE----- --wkGn4FMlE2lkbr1wW6OgfliXkuIoHwFin--