From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZelDR-0005NP-GT for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:40:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZelDL-0003Yg-Dj for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:40:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60132) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZelDL-0003Wi-6W for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:40:07 -0400 References: <7567ba6259b039b5d89faf658c8f52d500e2595c.1443017811.git.DirtY.iCE.hu@gmail.com> From: Eric Blake Message-ID: <5602B9C5.9020505@redhat.com> Date: Wed, 23 Sep 2015 08:40:05 -0600 MIME-Version: 1.0 In-Reply-To: <7567ba6259b039b5d89faf658c8f52d500e2595c.1443017811.git.DirtY.iCE.hu@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="82M3LXuBbPot6kV9g9NPu3356mphL5dlX" Subject: Re: [Qemu-devel] [PATCH v2 1/3] qapi: convert NumaOptions into a flat union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?S8WRdsOhZ8OzLCBab2x0w6Fu?= , qemu-devel@nongnu.org Cc: Eduardo Habkost , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --82M3LXuBbPot6kV9g9NPu3356mphL5dlX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/23/2015 08:27 AM, K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n wrote: > Changes the NumaOptions to flat union from a simple one. This is > required by my later OptsVisitor patch to preserve backward > compatibility. >=20 > Strictly speaking this would break QMP compatibility (as specified in > docs/qapi-code-gen.txt), but since no QMP command use this structure, > it's not an issue. The -numa option syntax doesn't change. There are > some changes in the C api, but this patch fixes them. >=20 > Signed-off-by: K=C5=91v=C3=A1g=C3=B3, Zolt=C3=A1n > Reviewed-by: Eric Blake >=20 > --- >=20 > Changes from v1: > * fixed documentation Since you're basing this on top of my pending series, why not take advantage of it... > +## > +# @NumaCommonOptions > +# > +# Common set of numa options. > +# > +# @type: NUMA command-line option type. > +# > +# Since: 2.5 > +## > +{ 'struct': 'NumaCommonOptions', > + 'data': { > + 'type': 'NumaOptionType' } } =2E..by dropping this type, and instead... > + > +## > +# @NumaOptions > +# =2E..document @type here, and... > +# A discriminated record of NUMA options. (for OptsVisitor) > +# > +# Since 2.1 > +## > +{ 'union': 'NumaOptions', > + 'base': 'NumaCommonOptions', =2E..write this as 'base': { 'type': 'NumaOptionType' }, > + 'discriminator': 'type', > + 'data': { > + 'node': 'NumaNodeOptions' }} > + > +## > # @HostMemPolicy > # > # Host memory policy types >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --82M3LXuBbPot6kV9g9NPu3356mphL5dlX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWArnFAAoJEKeha0olJ0NqAtYH/RbYTGKqTFtZMzMrH4Far+PI 7WVn6gHODFh+ivIqk835PgrA9aGRAyeFZHetm32f6tJMYTrjyvJ02gIaT4iUcPjz Q5EKWdEfQ6ugye+WQKtaUQB737ujgRtK1QJ/gwf1AHY0o2r5FdqEDTclOyEqLnsW Cap9qAJdEv6B7iVoaJkurykYYhu1+HVCFg3zBrFmCZvlv9rOv6fqg5fdOFhro4/C TRKELBC6NRpn8SZE1N9JOa9+EbMWT/cjJ6ODfHbRQdvtGVimr3Yxmi6XAT0+ZmRK QBf05aHFo26Iq7F7sXfmX7pNaVTGeDyKdq2xA4tczihWIMFONJYqzfR7sSva3H8= =yPQg -----END PGP SIGNATURE----- --82M3LXuBbPot6kV9g9NPu3356mphL5dlX--