From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47389) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZelNk-0001Nw-Qx for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:50:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZelNf-0001RV-RH for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:50:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZelNf-0001Pa-M9 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 10:50:47 -0400 References: <1443017892-15567-1-git-send-email-drjones@redhat.com> From: Wei Huang Message-ID: <5602BC44.5010200@redhat.com> Date: Wed, 23 Sep 2015 09:50:44 -0500 MIME-Version: 1.0 In-Reply-To: <1443017892-15567-1-git-send-email-drjones@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: smbios: inform guest of kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 9/23/15 09:18, Andrew Jones wrote: > ARM/AArch64 KVM guests don't have any way to identify > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > could discuss all sorts of reasons why guests shouldn't need to > know that, but then there's always some case where it'd be One example is for the subscription manager to check the license type... > nice... Anyway, now that we have SMBIOS tables in ARM guests, > it's easy for the guest to know that it's a QEMU instance. This > patch takes that one step further, also identifying KVM, when > appropriate. Again, we could debate why generally nothing > should care whether it's of type QEMU or QEMU/KVM, but again, > sometimes it's nice to know... > > Signed-off-by: Andrew Jones > --- > hw/arm/virt.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 6bf0d6d591d6c..607d448354a8c 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -855,12 +855,17 @@ static void virt_build_smbios(VirtGuestInfo *guest_info) > FWCfgState *fw_cfg = guest_info->fw_cfg; > uint8_t *smbios_tables, *smbios_anchor; > size_t smbios_tables_len, smbios_anchor_len; > + const char *product = "QEMU Virtual Machine"; > > if (!fw_cfg) { > return; > } > > - smbios_set_defaults("QEMU", "QEMU Virtual Machine", > + if (kvm_enabled()) { > + product = "KVM Virtual Machine"; > + } > + > + smbios_set_defaults("QEMU", product, > "1.0", false, true, SMBIOS_ENTRY_POINT_30); > > smbios_get_tables(NULL, 0, &smbios_tables, &smbios_tables_len, > Reviewed-by: Wei Huang