From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zem9g-00052J-T8 for qemu-devel@nongnu.org; Wed, 23 Sep 2015 11:40:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zem9b-0007js-Ta for qemu-devel@nongnu.org; Wed, 23 Sep 2015 11:40:24 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:35581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zem9b-0007jd-Ne for qemu-devel@nongnu.org; Wed, 23 Sep 2015 11:40:19 -0400 Received: by wicge5 with SMTP id ge5so213375032wic.0 for ; Wed, 23 Sep 2015 08:40:18 -0700 (PDT) Sender: Paolo Bonzini References: <1442872682-6523-1-git-send-email-eblake@redhat.com> <1442872682-6523-46-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: <5602C7DE.10701@redhat.com> Date: Wed, 23 Sep 2015 17:40:14 +0200 MIME-Version: 1.0 In-Reply-To: <1442872682-6523-46-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 45/46] net: Complete qapi-fication of netdev_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, Jason Wang , armbru@redhat.com, ehabkost@redhat.com, DirtY.iCE.hu@gmail.com On 21/09/2015 23:58, Eric Blake wrote: > We finally have all the required pieces for doing a type-safe > representation of netdev_add as a flat union, where the > discriminator 'type' now selects which additional members may > appear in the "arguments" JSON object sent over QMP, while > making no changes to the set of previously-valid QMP commands > that would work, and without breaking command line parsing. Is this still type-unsafe like the old netdev_add (e.g. accepts a string for an integer)? Paolo