From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zf63S-0002HC-RN for qemu-devel@nongnu.org; Thu, 24 Sep 2015 08:55:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zf63R-0002Jn-Lc for qemu-devel@nongnu.org; Thu, 24 Sep 2015 08:55:18 -0400 References: <1443086067-8209-1-git-send-email-kwolf@redhat.com> From: Eric Blake Message-ID: <5603F2A8.9010905@redhat.com> Date: Thu, 24 Sep 2015 06:55:04 -0600 MIME-Version: 1.0 In-Reply-To: <1443086067-8209-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jJrMJX4vHJ28gnwQhlBvIfvvAIKuuP41N" Subject: Re: [Qemu-devel] [PATCH] raw-win32: Fix write request error handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, guangmuzhu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jJrMJX4vHJ28gnwQhlBvIfvvAIKuuP41N Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/24/2015 03:14 AM, Kevin Wolf wrote: > aio_worker() wrote the return code to the wrong variable. >=20 > Signed-off-by: Kevin Wolf > Tested-by: Guangmu Zhu > --- > block/raw-win32.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake >=20 > diff --git a/block/raw-win32.c b/block/raw-win32.c > index 68f2338..b562c94 100644 > --- a/block/raw-win32.c > +++ b/block/raw-win32.c > @@ -119,9 +119,9 @@ static int aio_worker(void *arg) > case QEMU_AIO_WRITE: > count =3D handle_aiocb_rw(aiocb); > if (count =3D=3D aiocb->aio_nbytes) { > - count =3D 0; > + ret =3D 0; > } else { > - count =3D -EINVAL; > + ret =3D -EINVAL; > } > break; > case QEMU_AIO_FLUSH: >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jJrMJX4vHJ28gnwQhlBvIfvvAIKuuP41N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWA/KoAAoJEKeha0olJ0NqN0cH/ii98zXZQLSaVKdVPiYXCM4O AaLBIsU3UebYdCGyWZYvP5N+N3mdNgpBot3KiCENKRAjLtstZw9AjcpvLt/sVruD 0lxzZbImL1cpzrLLzegT1oJ7+/+u2/uNc6MwPGqJXzeC8D/+xyzPE9PL3f2l7U7I LCbPc53vNqA7RdXwKYBF5VXFQSQmw0Oebuf55vWrAE85O6+OVIwC4vgA0yzSbELp ewJuz9Vz3hIcTSx5p/VKn+stZ7NfS4shUHAz5ojvpRSB9AweE7s5lv0zf+0I1EOT rrxU4SMbCk4r8ljuwS1g5IfoS4EQBWrZ2FIBPwJcN4QTzVrDHTdHKhwy2xse72M= =kykI -----END PGP SIGNATURE----- --jJrMJX4vHJ28gnwQhlBvIfvvAIKuuP41N--