From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60774)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZfLYX-0004Cx-MU
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:28:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1ZfLYU-0004cY-7M
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 01:28:25 -0400
References: <1441210493-19591-1-git-send-email-stefanha@redhat.com>
	<1441210493-19591-7-git-send-email-stefanha@redhat.com>
	<20150903101919.628d67ff@pixies> <20150924141912.556ed664@pixies>
From: Jason Wang <jasowang@redhat.com>
Message-ID: <5604DB75.4030404@redhat.com>
Date: Fri, 25 Sep 2015 13:28:21 +0800
MIME-Version: 1.0
In-Reply-To: <20150924141912.556ed664@pixies>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 6/7] vmxnet3: Drop
 net_vmxnet3_info.can_receive
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, qemu-stable <qemu-stable@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>



On 09/24/2015 07:19 PM, Shmulik Ladkani wrote:
> Hi,
>
> On Thu, 3 Sep 2015 10:19:19 +0300, shmulik.ladkani@ravellosystems.com wrote:
>> On Wed,  2 Sep 2015 17:14:52 +0100, stefanha@redhat.com wrote:
>>> From: Fam Zheng <famz@redhat.com>
>>>
>>> Commit 6e99c63 ("net/socket: Drop net_socket_can_send") changed the
>>> semantics around .can_receive for sockets to now require the device to
>>> flush queued pkts when transitioning to a .can_receive=true state. But
>>> it's OK to drop incoming packets when the link is not active.
>>>
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Tested-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
> Ping...
>
> I'm not sure what's the exact policy, but shouldn't
> '2734a20 vmxnet3: Drop net_vmxnet3_info.can_receive' go into stable-2.4?

If you think a patch is stable candidate. Need cc qemu-stable@nongnu.org
explicitly in the commit log.

Cc Michael for this.

>
> Otherwise, vmxnet3 has no rx connectivity in 2.4 based releases.
>
> See here: 
> https://lists.gnu.org/archive/html/qemu-devel/2015-08/msg02233.html
>
> Regards,
> Shmulik