From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfNuA-0000Xn-Q5 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 03:58:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfNu7-0006r6-Kf for qemu-devel@nongnu.org; Fri, 25 Sep 2015 03:58:54 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:53486 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfNu7-0006nx-9q for qemu-devel@nongnu.org; Fri, 25 Sep 2015 03:58:51 -0400 Message-ID: <5604FEB5.3080903@kamp.de> Date: Fri, 25 Sep 2015 09:58:45 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1443084128-25552-1-git-send-email-kraxel@redhat.com> <1443084128-25552-9-git-send-email-kraxel@redhat.com> In-Reply-To: <1443084128-25552-9-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RfC PATCH 08/10] name vnc buffers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Am 24.09.2015 um 10:42 schrieb Gerd Hoffmann: > Signed-off-by: Gerd Hoffmann > --- > ui/vnc-jobs.c | 1 + > ui/vnc.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+) > > diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c > index 9824c34..7a234da 100644 > --- a/ui/vnc-jobs.c > +++ b/ui/vnc-jobs.c > @@ -303,6 +303,7 @@ static VncJobQueue *vnc_queue_init(void) > > qemu_cond_init(&queue->cond); > qemu_mutex_init(&queue->mutex); > + qio_buffer_init(&queue->buffer, "vnc-job-queue"); > QTAILQ_INIT(&queue->jobs); > return queue; > } > diff --git a/ui/vnc.c b/ui/vnc.c > index e4b0e3a..fc0311f 100644 > --- a/ui/vnc.c > +++ b/ui/vnc.c > @@ -2978,6 +2978,22 @@ static void vnc_connect(VncDisplay *vd, int csock, > vs->csock = csock; > vs->vd = vd; > > + qio_buffer_init(&vs->input, "vnc-input/%d", csock); > + qio_buffer_init(&vs->output, "vnc-output/%d", csock); > + qio_buffer_init(&vs->ws_input, "vnc-ws_input/%d", csock); > + qio_buffer_init(&vs->ws_output, "vnc-ws_output/%d", csock); > + qio_buffer_init(&vs->jobs_buffer, "vnc-jobs_buffer/%d", csock); > + > + qio_buffer_init(&vs->tight.tight, "vnc-tight/%d", csock); > + qio_buffer_init(&vs->tight.zlib, "vnc-tight-zlib/%d", csock); > + qio_buffer_init(&vs->tight.gradient, "vnc-tight-gradient/%d", csock); > + qio_buffer_init(&vs->tight.jpeg, "vnc-tight-jpeg/%d", csock); > + qio_buffer_init(&vs->tight.png, "vnc-tight-png/%d", csock); > + qio_buffer_init(&vs->zlib.zlib, "vnc-zlib/%d", csock); > + qio_buffer_init(&vs->zrle.zrle, "vnc-zrle/%d", csock); > + qio_buffer_init(&vs->zrle.fb, "vnc-zrle-fb/%d", csock); > + qio_buffer_init(&vs->zrle.zlib, "vnc-zrle-zlib/%d", csock); > + > if (skipauth) { > vs->auth = VNC_AUTH_NONE; > vs->subauth = VNC_AUTH_INVALID; You also might want to name this one: diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index dfc5139..65bae26 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -211,6 +211,8 @@ static int vnc_worker_thread_loop(VncJobQueue *queue) int n_rectangles; int saved_offset; + qio_buffer_init(&vs.output, "vnc-worker_output"); + vnc_lock_queue(queue); while (QTAILQ_EMPTY(&queue->jobs) && !queue->exit) { qemu_cond_wait(&queue->cond, &queue->mutex); Peter