Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter

[Thomas Huth <thuth@redhat.com>]

On 25/09/15 10:03, Yang Hongyang wrote:
> 
> 
> On 09/24/2015 05:12 PM, Markus Armbruster wrote:
>> Yang Hongyang <yanghy@cn.fujitsu.com> writes:
> [...]
>>> diff --git a/vl.c b/vl.c
>>> index ec589e2..3cf89d5 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -2794,7 +2794,12 @@ static bool object_create_initial(const char
>>> *type)
>>>       if (g_str_equal(type, "rng-egd")) {
>>>           return false;
>>>       }
>>> -    /* TODO: return false for concrete netfilters */
>>> +
>>> +    /* return false for concrete netfilters */
>>
>> I find this comment useless, please drop it :)
> 
> This might be useful for reminding others who wants to implement other
> filters.

I think the comment should explain why the code is return false here,
not what the code is doing (which is obvious). So maybe something like:

    /*
     * netfilters require that the corresponding
     * netdevs are already existing
     */

?

 Thomas