From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35723)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZfODI-0002kc-MR
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:18:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZfODH-0000f0-Ri
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:18:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40887)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1ZfODH-0000ew-N4
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 04:18:39 -0400
References: <1442405768-23019-1-git-send-email-yanghy@cn.fujitsu.com>
	<1442405768-23019-10-git-send-email-yanghy@cn.fujitsu.com>
	<87si64qiyr.fsf@blackfin.pond.sub.org>
	<5604FFBB.5080701@cn.fujitsu.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <5605035B.8070305@redhat.com>
Date: Fri, 25 Sep 2015 10:18:35 +0200
MIME-Version: 1.0
In-Reply-To: <5604FFBB.5080701@cn.fujitsu.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v11 09/12] netfilter: add a netbuffer filter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Yang Hongyang <yanghy@cn.fujitsu.com>, Markus Armbruster <armbru@redhat.com>
Cc: jasowang@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org, lizhijian@cn.fujitsu.com, zhang.zhanghailiang@huawei.com

On 25/09/15 10:03, Yang Hongyang wrote:
> 
> 
> On 09/24/2015 05:12 PM, Markus Armbruster wrote:
>> Yang Hongyang <yanghy@cn.fujitsu.com> writes:
> [...]
>>> diff --git a/vl.c b/vl.c
>>> index ec589e2..3cf89d5 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -2794,7 +2794,12 @@ static bool object_create_initial(const char
>>> *type)
>>>       if (g_str_equal(type, "rng-egd")) {
>>>           return false;
>>>       }
>>> -    /* TODO: return false for concrete netfilters */
>>> +
>>> +    /* return false for concrete netfilters */
>>
>> I find this comment useless, please drop it :)
> 
> This might be useful for reminding others who wants to implement other
> filters.

I think the comment should explain why the code is return false here,
not what the code is doing (which is obvious). So maybe something like:

    /*
     * netfilters require that the corresponding
     * netdevs are already existing
     */

?

 Thomas