From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ2k-0006lR-7H for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:15:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfQ2g-0006Cf-Tl for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:15:54 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:38874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ2g-0006BF-NY for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:15:50 -0400 Received: by wiclk2 with SMTP id lk2so13153642wic.1 for ; Fri, 25 Sep 2015 03:15:50 -0700 (PDT) Sender: Paolo Bonzini References: <1442582350-9179-1-git-send-email-berrange@redhat.com> <1442582350-9179-17-git-send-email-berrange@redhat.com> From: Paolo Bonzini Message-ID: <56051ED2.1080808@redhat.com> Date: Fri, 25 Sep 2015 12:15:46 +0200 MIME-Version: 1.0 In-Reply-To: <1442582350-9179-17-git-send-email-berrange@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 16/16] io: add QIOChannelBuffer class List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: "Dr. David Alan Gilbert" , Gerd Hoffmann On 18/09/2015 15:19, Daniel P. Berrange wrote: > + if (fds || nfds) { > + error_setg_errno(errp, EINVAL, > + "Channel does not support buffer descriptor passing"); > + return -1; > + } Typo (file descriptor passing) and the check could be hoisted to io/channel.c by using features. In fact capabilities could perhaps be stored statically in struct QIOChannel as a bitmap? Paolo