From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ4T-0000CO-1F for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:17:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfQ4P-00080w-R9 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:17:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ4P-00080Z-MP for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:17:37 -0400 References: <1443121042-3409-1-git-send-email-armbru@redhat.com> <1443121042-3409-5-git-send-email-armbru@redhat.com> From: Thomas Huth Message-ID: <56051F3D.70900@redhat.com> Date: Fri, 25 Sep 2015 12:17:33 +0200 MIME-Version: 1.0 In-Reply-To: <1443121042-3409-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: afaerber@suse.de, stefanha@redhat.com, ehabkost@redhat.com On 24/09/15 20:57, Markus Armbruster wrote: > The test doesn't check that the output makes any sense, only that QEMU > survives. Useful since we've had an astounding number of crash bugs > around there. > > In fact, we have a bunch of them right now: several devices crash or > hang, and all CPUs leave a dangling pointer behind. The test skips > testing the broken parts. The next commits will fix them, and drop > the skipping. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > tests/Makefile | 8 ++- > tests/device-introspect-test.c | 153 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 158 insertions(+), 3 deletions(-) > create mode 100644 tests/device-introspect-test.c Hi Markus, just a quick note: When I run the tester directly, it aborts: $ tests/boot-order-test ** ERROR:/home/thuth/devel/qemu/tests/libqtest.c:517:qtest_get_arch: assertion failed: (qemu != NULL) Aborted (core dumped) ... that's a little bit ugly, maybe you could print the help text instead? Thomas