From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ4y-0000nj-M8 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:18:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfQ4v-0008Sy-A5 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:18:12 -0400 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:38145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ4v-0008SB-4B for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:18:09 -0400 Received: by wiclk2 with SMTP id lk2so13227788wic.1 for ; Fri, 25 Sep 2015 03:18:08 -0700 (PDT) Sender: Paolo Bonzini References: <1442582350-9179-1-git-send-email-berrange@redhat.com> <56014838.6020109@redhat.com> <20150924145153.GH31980@redhat.com> From: Paolo Bonzini Message-ID: <56051F5D.5020601@redhat.com> Date: Fri, 25 Sep 2015 12:18:05 +0200 MIME-Version: 1.0 In-Reply-To: <20150924145153.GH31980@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v1 00/16] Introduce I/O channels framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Gerd Hoffmann , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org On 24/09/2015 16:51, Daniel P. Berrange wrote: > Thanks, I'd still love one or more people to do a detailed review of > the I/O channel implementations before I think about sending a PULL > request, since there's a fair amount of code in there.... I did a review of the file, socket, command and buffer code. I made another small suggestion regarding error checking. The command code could add support for shutdown by closing the parent's end of the pipe. It can be useful to avoid deadlocks in bidirectional pipes. > I'm curious now as to which bit you might be refering to here :-) IIRC > the only place I had any interaction with coroutines was the migration > code QEMUFile implementation, where I need to yield when reads block. I think it was NBD. Paolo