From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ5p-00023t-Sd for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfQ5m-0000jU-Fx for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:19:05 -0400 Received: from mx2.suse.de ([195.135.220.15]:59303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfQ5m-0000hJ-60 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 06:19:02 -0400 References: <1443121042-3409-1-git-send-email-armbru@redhat.com> <1443121042-3409-5-git-send-email-armbru@redhat.com> <56051F3D.70900@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <56051F93.3050800@suse.de> Date: Fri, 25 Sep 2015 12:18:59 +0200 MIME-Version: 1.0 In-Reply-To: <56051F3D.70900@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: stefanha@redhat.com, Markus Armbruster , ehabkost@redhat.com, qemu-devel@nongnu.org Am 25.09.2015 um 12:17 schrieb Thomas Huth: > On 24/09/15 20:57, Markus Armbruster wrote: >> The test doesn't check that the output makes any sense, only that QEMU >> survives. Useful since we've had an astounding number of crash bugs >> around there. >> >> In fact, we have a bunch of them right now: several devices crash or >> hang, and all CPUs leave a dangling pointer behind. The test skips >> testing the broken parts. The next commits will fix them, and drop >> the skipping. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- >> tests/Makefile | 8 ++- >> tests/device-introspect-test.c | 153 ++++++++++++++++++++++++++++++++= +++++++++ >> 2 files changed, 158 insertions(+), 3 deletions(-) >> create mode 100644 tests/device-introspect-test.c >=20 > Hi Markus, >=20 > just a quick note: When I run the tester directly, it aborts: >=20 > $ tests/boot-order-test > ** > ERROR:/home/thuth/devel/qemu/tests/libqtest.c:517:qtest_get_arch: > assertion failed: (qemu !=3D NULL) > Aborted (core dumped) >=20 > ... that's a little bit ugly, maybe you could print the help text inste= ad? That's got nothing to do with his test, all QTests require environment variables set in the Makefile. Feel free to send a patch for qtest.c. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N= =C3=BCrnberg)