From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45614)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZfSMI-0008SP-P8
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 08:44:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZfSMD-0006FU-1q
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 08:44:14 -0400
Received: from mx2.suse.de ([195.135.220.15]:40146)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZfSMC-0006FK-SZ
	for qemu-devel@nongnu.org; Fri, 25 Sep 2015 08:44:09 -0400
References: <1443184788-18859-1-git-send-email-afaerber@suse.de>
	<1443184788-18859-7-git-send-email-afaerber@suse.de>
	<56054133.3080108@redhat.com>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <56054198.1000400@suse.de>
Date: Fri, 25 Sep 2015 14:44:08 +0200
MIME-Version: 1.0
In-Reply-To: <56054133.3080108@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll()
	signature
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Bruce Rogers <brogers@suse.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Lin Ma <lma@suse.com>

Am 25.09.2015 um 14:42 schrieb Paolo Bonzini:
> On 25/09/2015 14:39, Andreas F=C3=A4rber wrote:
>> Instead of using int64_t for qemu_strtoll() and uiint64_t for
>> qemu_strtoull(), use long long and unsigned long long as their name
>> implies.
>>
>> The only affected callers are our test cases.
>>
>> This prepares for following checkpatch's recommendation of using it mo=
re,
>> by making it easier to switch from POSIX to QEMU versions.
>> Remaining difference is const-ness.
>=20
> Do we actually use long long and unsigned long long anywhere?

The next patch does, because checkpatch asks for it. :)

qemu_strtoull() has some special handling for Windows apparently.

Cheers,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Felix Imend=C3=B6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=
=C3=BCrnberg)