From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfU18-000869-QH for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfU13-0002v1-7i for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:30:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfU13-0002ux-2z for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:30:25 -0400 References: <1443168480-5067-1-git-send-email-yanghy@cn.fujitsu.com> From: Eric Blake Message-ID: <56055A7F.1090700@redhat.com> Date: Fri, 25 Sep 2015 08:30:23 -0600 MIME-Version: 1.0 In-Reply-To: <1443168480-5067-1-git-send-email-yanghy@cn.fujitsu.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JjqqD5n1RhQmXbIfQ7vP775k5eHfJfpbB" Subject: Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yang Hongyang , qemu-devel@nongnu.org Cc: jasowang@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JjqqD5n1RhQmXbIfQ7vP775k5eHfJfpbB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 02:08 AM, Yang Hongyang wrote: > This patchset addressed Markus comment on netfilter patch > series, most of them are comment fixes. >=20 > It is based on jason's net tree: > https://github.com/jasowang/qemu/tree/net If that tree is not yet merged mainline, wouldn't it be better to squash these fixes directly into the offending patches, instead of using it as a followup patch? > /* > - * we return size when buffer a packet, the sender will take it as= > - * a already sent packet, so sent_cb should not be called later > - * FIXME: even if guest can't receive packet for some reasons. Fil= ter > + * We return size when buffer a packet, the sender will take it as= > + * a already sent packet, so sent_cb should not be called later. s/a already/an already/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --JjqqD5n1RhQmXbIfQ7vP775k5eHfJfpbB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBVp/AAoJEKeha0olJ0NqhpsH/iHvChniq8oa0mBA9X6XUy52 xSO7BI0arT+gPYdBrO8quHjzc44NMhVQdHW41IJQ0bejo8URmSyjdNbFZ2wPRcvd Otji4z1ztxeVWx/kgDtcr54gSn5bkZqeZyNvKlFaAQQzeCSMKcBjMbvzonAOP+D2 Kl3/v18BptWevlr/lStce3NfYpmGNQH+JPsJGS1j2TaWc9DQ5nSSwBJlVSbklyCt l233Bbd03O6Fwvc2Y4F5ZGftkvwSf4ONlr9CWKOBPXFfoOwwFWLgsjvGAcaoYDfL WHLlqu6TxpY75nQetu0iClxy6kYKKQpeje6DDFYcd4wCpvFnfpTOMKhDBtmnUYk= =hwGv -----END PGP SIGNATURE----- --JjqqD5n1RhQmXbIfQ7vP775k5eHfJfpbB--