From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUKZ-0007D1-9V for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:50:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfUKW-0007NX-4X for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:50:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUKV-0007NS-Vt for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:50:32 -0400 References: <1443184788-18859-1-git-send-email-afaerber@suse.de> <1443184788-18859-3-git-send-email-afaerber@suse.de> From: Eric Blake Message-ID: <56055F36.8000306@redhat.com> Date: Fri, 25 Sep 2015 08:50:30 -0600 MIME-Version: 1.0 In-Reply-To: <1443184788-18859-3-git-send-email-afaerber@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qachNE2VjJ4CpvfTCsh8tkT6I9dx75sTs" Subject: Re: [Qemu-devel] [PATCH 2/7] test-string-input-visitor: Add int test case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Bruce Rogers , Lin Ma , Markus Armbruster , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qachNE2VjJ4CpvfTCsh8tkT6I9dx75sTs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 06:39 AM, Andreas F=C3=A4rber wrote: > In addition to -42 also parse the maximum int64. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > tests/test-string-input-visitor.c | 8 ++++++++ > 1 file changed, 8 insertions(+) Shouldn't we also add tests of one-beyond-range, to have coverage of expected error behavior when a number is too large in magnitude? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qachNE2VjJ4CpvfTCsh8tkT6I9dx75sTs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBV82AAoJEKeha0olJ0Nq7qkIAJcd/apUg2e8NJfXT1/MGFQG 9F32N7TM0dTabi5ICbDhsRXBg/yObyprLjXZeTHVh/jAyG6E95dZgK4YWCNRHAiW 8jmHQKThl6qZvwio10bsDiAcnmaeBoLZiE64chRPoTrKlcrTz1z4r4Kc5FvYtkO8 QUyqI7Cc386tgHoWg212X9Z8X6O2mzeTFyM/nkAoKZXhMPsDNFUzt1tdE4Ei6AIj wDODQn7/uE6KXAVcqcQo29b48qLmnIJyG6MXeQcHES0n3mb5rLGdOc4P+BweNHUy o3sswJSJTAvqWMe1g3vzbhTfqHTCNzHZH8UbxnY99oYr91RGvdO9raZcPQY2CVM= =P4Eq -----END PGP SIGNATURE----- --qachNE2VjJ4CpvfTCsh8tkT6I9dx75sTs--