From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUPq-0001rn-FH for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:56:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfUPm-0002wd-25 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:56:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49479) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUPl-0002v7-Sz for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:55:58 -0400 References: <1443184788-18859-1-git-send-email-afaerber@suse.de> <1443184788-18859-4-git-send-email-afaerber@suse.de> From: Eric Blake Message-ID: <5605607B.9030905@redhat.com> Date: Fri, 25 Sep 2015 08:55:55 -0600 MIME-Version: 1.0 In-Reply-To: <1443184788-18859-4-git-send-email-afaerber@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i6cD8wh0wa0vTa4INg3hX6sSmBvPG03d6" Subject: Re: [Qemu-devel] [PATCH 3/7] test-string-input-visitor: Add uint64 test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Bruce Rogers , Lin Ma , Markus Armbruster , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --i6cD8wh0wa0vTa4INg3hX6sSmBvPG03d6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 06:39 AM, Andreas F=C3=A4rber wrote: > Test parsing of decimal and hexadecimal uint64 numbers with most > significient bit set. s/significient/significant/ >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > tests/test-string-input-visitor.c | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) It would also be nice to add tests of one-beyond-range to make sure we are properly diagnosing range issues. And we need to make up our mind on whether "-1" is a parse error or accepted as a synonym for ULLONG_MAX when doing an unsigned parse. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --i6cD8wh0wa0vTa4INg3hX6sSmBvPG03d6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWB8AAoJEKeha0olJ0NqaIsIAI8u1j1eGm8uC3pjehEP4jPk S22/dEQc7qjZdyPmAoAkINnu/dJAR/3zSHrf9CSCurHE6B57+ZX1OM1PoQVPWE6R KCpXHd+TPcWdOBovQUPxyM8hth9TDofwYlFnjD0JOF/rsROu+ZssS/32RQDN7I0m HPrUeay90fuvbTAc1YlD9jsKV+CaBDNi0x1L9YRXLsN6Fy/JMTY0P4IK92bj8WB1 GBCkGwZVuw+tMJOdOl96T3Tc2WrCjlUI7q/nfqfaJSn2pGAXIGSbMm97MO0ZlgVW LiHjL6RFYGxAPZ3IQkEUTDBPVAkrUMDv9D3ztzaVRraOy/kp953tvZooog0msOM= =kTfg -----END PGP SIGNATURE----- --i6cD8wh0wa0vTa4INg3hX6sSmBvPG03d6--