From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUTZ-0005Zy-Am for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:59:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfUTU-0005Mz-CQ for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:59:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUTU-0005Mh-7N for qemu-devel@nongnu.org; Fri, 25 Sep 2015 10:59:48 -0400 References: <1443184788-18859-1-git-send-email-afaerber@suse.de> <1443184788-18859-7-git-send-email-afaerber@suse.de> From: Eric Blake Message-ID: <56056162.9090900@redhat.com> Date: Fri, 25 Sep 2015 08:59:46 -0600 MIME-Version: 1.0 In-Reply-To: <1443184788-18859-7-git-send-email-afaerber@suse.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="W4jpuRLEFvquQtKgXXXBJQFTFbIdBdOs9" Subject: Re: [Qemu-devel] [PATCH 6/7] cutils: Normalize qemu_strto[u]ll() signature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Andreas_F=c3=a4rber?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , Bruce Rogers , Lin Ma , Markus Armbruster , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --W4jpuRLEFvquQtKgXXXBJQFTFbIdBdOs9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 06:39 AM, Andreas F=C3=A4rber wrote: > Instead of using int64_t for qemu_strtoll() and uiint64_t for s/uiint64/uint64/ > qemu_strtoull(), use long long and unsigned long long as their name > implies. >=20 > The only affected callers are our test cases. >=20 > This prepares for following checkpatch's recommendation of using it mor= e, > by making it easier to switch from POSIX to QEMU versions. > Remaining difference is const-ness. >=20 > Signed-off-by: Andreas F=C3=A4rber > --- > include/qemu-common.h | 4 +-- > tests/test-cutils.c | 76 +++++++++++++++++++++++++------------------= -------- > util/cutils.c | 4 +-- > 3 files changed, 42 insertions(+), 42 deletions(-) I concur with Paolo's suggestion to instead rename the functions to make it obvious that we are parsing [u]int64, since that is more likely to match the type that the bulk of callers will already have on hand. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --W4jpuRLEFvquQtKgXXXBJQFTFbIdBdOs9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWFiAAoJEKeha0olJ0NqcIkIAKV/OqjI0NAp3gxkfWybEHyR uFTmyfTgU92avzG25r9xpKwgSwqtUYVaHn59audGyb2dBwCnSDTpeeDjKApRJNnT h7xsmqGcrZf2pLyStCogXNxwm/1c9PHhIOxAUAXGDhuDIOBOJqsuhjgQ4fmnBAp6 PpkBIfPRc8ABnb/izLQvJ6RFe+EYQ9/WbdKXY9lqUzxbfrCQwjxuNsJ9E6M6J0nM vDxk2a5bkOVPenB6y1UmXAPU8Yawpguo5dPOvNm/4U24o9phZbPbZUy+PyGbJEDb 67I/5kaQedPiihBL1W5hWSnSzroNjhoCKwnQ1xX3PJXrWjKsPZPtvH/nBZYTOJI= =T6lC -----END PGP SIGNATURE----- --W4jpuRLEFvquQtKgXXXBJQFTFbIdBdOs9--