From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUWl-0007cq-Hr for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:03:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfUWf-0000QL-N4 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:03:11 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-2-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <56056226.9030804@redhat.com> Date: Fri, 25 Sep 2015 09:03:02 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-2-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HPDrjBqxgPMJ2TKlEh5rW9cld49704aDa" Subject: Re: [Qemu-devel] [PATCH 01/36] qapi: add comment block before ChardevDummy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: qemu-trivial , armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HPDrjBqxgPMJ2TKlEh5rW9cld49704aDa Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > This is mainly to please the doc generation that requires comment block= > before the declaration. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qapi-schema.json | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake Could be taken through trivial branch now without waiting for pending qapi patches, hence I've added a cc. >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 516c95b..3e2e53d 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -3042,13 +3042,17 @@ > { 'struct': 'ChardevRingbuf', 'data': { '*size' : 'int' } } > =20 > ## > +# @ChardevDummy > +## > +{ 'struct': 'ChardevDummy', 'data': { } } I might eventually reach the point where we could use: { 'union': 'ChardevBackend', 'data': { ... 'pty': {}, =2E.. } } instead of needing 'pty': 'ChardevDummy'. But my current pending series doesn't get us quite there yet, so it would be a separate cleanup anyways= =2E --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HPDrjBqxgPMJ2TKlEh5rW9cld49704aDa Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWImAAoJEKeha0olJ0Nq7JAIAIZbu8JUQZjNah7ScnksqhKf G/xOCPqeLhuprvNwHq695h6ibnh3qchufZYT1C8Kl+pT7UKVKvJZnRUAUJxprAzG QTyV5/k6c2AdUVvhHzYf0gnpbVyCzv/v74RaWRLOGEolMxHeMp4EjBUH7EyORmtN vTQFaGjb5K7QfqGW4rtyPKY6A2k05/XD3FuoEwUTobYnOOn8nLyC7Qs73j8dIp7B o1kCvPmG9XJQTzj3Zt8IwEmayPEjZa/759d1tbdpmfbqIEQjT9kFNaG1Shn9Nmbp jDWV0h3H6AMtrG3hUF1/TNhpw/ke4hDkzmINeJcyoi4iQwSAC2N5h9YR2xRCeIQ= =VrTA -----END PGP SIGNATURE----- --HPDrjBqxgPMJ2TKlEh5rW9cld49704aDa--