From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUd7-0007kb-Vk for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:10:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfUct-0005mw-CW for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:09:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfUct-0005mp-81 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:09:31 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-5-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <560563A9.9080003@redhat.com> Date: Fri, 25 Sep 2015 09:09:29 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-5-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="teFQDwvsuVfPpkcGGgrp3f7wcT9r4C89c" Subject: Re: [Qemu-devel] [PATCH 04/36] monitor: use qapi for qmp_capabilities command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --teFQDwvsuVfPpkcGGgrp3f7wcT9r4C89c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > This was initially done to add qmp_capabilities documentation to the > schema. Then I figured it would also help to get rid of the "middle > mode" monitor dispatch code. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > monitor.c | 4 ++-- > qapi-schema.json | 17 +++++++++++++++++ > qmp-commands.hx | 2 +- > 3 files changed, 20 insertions(+), 3 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -21,6 +21,23 @@ > { 'include': 'qapi/introspect.json' } > =20 > ## > +# @qmp_capabilities: > +# > +# Enable QMP capabilities. > +# > +# Arguments: None. > +# > +# Example: > +# > +# -> { "execute": "qmp_capabilities" } > +# <- { "return": {} } > +# > +# Notes: This command must be issued before issuing any other command.= I'd also mention that it is only accepted once; maybe this is better? Notes: This command is valid exactly when first connecting: it must be issued before any other command will be accepted, and will fail once the monitor is accepting other commands. Otherwise, I'm a fan of this patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --teFQDwvsuVfPpkcGGgrp3f7wcT9r4C89c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWOpAAoJEKeha0olJ0NqVZYIAJd71mvCfY4C6tWvtFDDGlJD LeQLEYMdSKEYQ+qPKuD1Rwv4OVXmCrrsLeAa15yh0nStxxR6KRz7u7bYuC/3as8E TnQ3iZG5nLC17KOkBw11BW9DhCVi+v3qrOGS/QSUpp66MUNLkXiy5tE8YxUim5HD F1qL+szFF03WJRmf0rH5e3sbbPz0aN8Xw6CHE8X0453zxoeLivnXsXt6CWzQCY02 lig6Jce4P9qYl5kq8ojxNovkj37qE3WDlwVwtKlnOD8Y5Mx9vhEbXuDSXSPt0HR2 Lohcj+QkZNLKtx9ZiwDlp4+giuo1dN6f2eU7zAVBKOTOGMgw4SVqsRZbgSHHkr0= =QNWJ -----END PGP SIGNATURE----- --teFQDwvsuVfPpkcGGgrp3f7wcT9r4C89c--